Time - Hannah J & Vera by veralizeth · Pull Request #8 · Ada-C13/oo-ride-share

veralizeth · 2020-02-28T20:33:53Z

Assignment Submission: OO Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question	Answer
How did getting up to speed on the existing codebase go? If it went well, what worked? If it didn't go well, what will you do differently next time?	We think it went well. What we did was to read first and make diagrams. From there, we tried to go through step by step depending the wave. We are so glad that we did this project as a pair.
What inheritance relations exist between classes?	We have a super class, `CsvRecord` and we have subclasses, `Passenger`, `Driver` and `Trip`.
What composition relations exist between classes?	Passenger and Trip have one to many relationship. Driver and Trip also have one to many relationship. `TripDispatcher and Driver` & `TripDispatcher and Passenger` & `TripDispatcher and Trip` have also one to many relationships.
Describe a decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	During the Wave 4 part, we needed to figure out how to sort `available_drivers` array with `sorted trips` inside of the available drivers. We made a decision based on the test results by using "puts" and rubber ducking each other.
Give an example of a template method that you implemented for this assignment	We have a template method, `self.from_csv` in `CsvRecord` class. We implemented this method in `Driver` & `Passenger` & `Trip` class
Give an example of a nominal test that you wrote for this assignment	For the `trip_dispatch_test`, we wrote a nominal test called "Selects an available driver and switch to an unavailable status" to make sure we have the correct status for each driver.
Give an example of an edge case test that you wrote for this assignment	For the `driver_test`, we wrote a edge case called "Returns the correct total revenue when the cost of a trip was less that $1.65" to handle the total revenue calculating the 80% of trip cost without subtracting the fee ($1.65)
What is a concept that you gained more clarity on as you worked on this assignment	By doing this project, we understood the concepts of `Inheritance (super class and subclasses)` and `object compositions`. It was very helpful for us to have diagrams to understand the (is a / has a) relationships . We were very glad to see the useful `template methods`, and learn when to use `helper methods`. Furthermore, we gained more clarity on how to use `before` blocks, nominal and edge cases in test files.
Collaps

…lso the trip_test

…l_revenue method and test)

… file)

CheezItMan · 2020-03-02T23:28:57Z

OO Ride Share

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
The code demonstrates individual learning about `Time` and the responsibility of `Trip.from_csv`, and uses `Time.parse` in `Trip.from_csv`	✔️
The code demonstrates breaking out complex logic in helper methods, such as making a helper method in `Trip` to calculate duration	✔️
There are tests for the nominal cases for the `Passenger#net_expenditures` and `Passenger#total_time_spent`	✔️
There is at least one edge case test for either `Passenger#net_expenditures` or `Passenger#total_time_spent` testing if the passenger has no trips	✔️
Practices inheritence. `Driver` inherits from `CsvRecord`, and implements `from_csv`	✔️
Employs problem-solving and implements `Driver#average_rating` and `Driver#total_revenue`	✔️
Implements the `TripDispatcher#request_trip`, which creates an instance of `Trip` with a driver and passenger, adds the new trip to `@trips`, and changes the status of the driver	✔️
Practices composition. In `TripDispatcher#request_trip`, the driver gets connected to the new trip, the passenger gets connected to the new trip	✔️
Practices git with at least 10 small commits and meaningful commit messages	✔️

Testing Requirements

Testing Requirement	yes/no
There is reasonable test coverage for wave 1, and all wave 1 tests pass	✔️
There is reasonable test coverage for wave 2, and all wave 2 tests pass	✔️
Wave 3: Tests in wave 1 and wave 2 explicitly test that only completed trips should be calculated (and ignore in-progress trips)	✔️
There is reasonable test coverage for `TripDispatcher#request_trip`, and all tests pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	8+ in Code Review && 3+ in Functional Requirements	✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Descriptive/Readable	✅
Logical/Organized	✅

Summary

Nice work, you hit all the learning goals here. Nice work on waves 1-3 especially the tests.

CheezItMan · 2020-03-02T23:15:49Z

lib/driver.rb

+        @trips.each do |trip|
+          total_rating += trip.rating
+        end
+       return (total_rating / @trips.length).round(2)


Suggested change

return (total_rating / @trips.length).round(2)

return (total_rating / @trips.length.to_f ).round(2)

CheezItMan · 2020-03-02T23:16:52Z

lib/driver.rb

+        if trip.cost >= 1.65
+          total_revenue += ((trip.cost - 1.65) * 0.80)
+          # QUESTION
+        elsif trip.cost < 1.65


You don't need the elsif since this is the exact opposite of the if.

Suggested change

elsif trip.cost < 1.65

else

CheezItMan · 2020-03-02T23:17:41Z

lib/trip.rb

+               start_time: Time.parse(record[:start_time]),
+               end_time: Time.parse(record[:end_time]),


CheezItMan · 2020-03-02T23:18:35Z

lib/trip_dispatcher.rb

+
+    def request_trip(passenger_id)
+
+      available_driver = find_frist_driver


spelling? frist?

Suggested change

available_driver = find_frist_driver

available_driver = find_first_driver

CheezItMan · 2020-03-02T23:18:48Z

lib/trip_dispatcher.rb

+
+
+    # Helper method
+    def find_frist_driver     


Suggested change

def find_frist_driver

def find_first_driver

CheezItMan · 2020-03-02T23:20:36Z

test/driver_test.rb

+
+    it "Returns total revenue across all their trips" do
+      #Assert
+      expect(@driver.total_revenue).must_be_close_to 9.28, 0.01


Good use of must_be_close_to

CheezItMan · 2020-03-02T23:21:28Z

test/driver_test.rb

@@ -132,5 +133,58 @@

  describe "total_revenue" do


You should also have tests for creating a driver with invalid arguments.

CheezItMan · 2020-03-02T23:22:15Z

test/passenger_test.rb

+    expect(passenger.net_expenditures).must_be_instance_of Float
+   end 
+
+   it "returns the correct net expenditures and total time spent if the passenger's trip is still in-progress" do 


veralizeth and others added 11 commits February 24, 2020 17:04

Adding the raise condition when start time is before the end time - A…

664121c

…lso the trip_test

Updated Wave 1 (net_expenditures & total_time_spent)

0f9fdd7

Updated wave 2(Driver class, updating trip)

eba5c28

Wave 2 (Find_driver method & connecting the drivers with trips - Tota…

a86d681

…l_revenue method and test)

Wave 3 (Request_trip method created)

c3310ba

Updated wave 3 (Modified request_trip method & added the related test…

7991bff

… file)

Updated Optional Wave 4 (Intelligent Dispatching)

219455e

Modified total_revenue method on driver.rb

9395c75

Modified total_revenue test on driver_test.rb

071c7ae

Changed the title of the test on trip_dispatch_test.rb

9009f54

Updated the reflection answers

bcb4217

CheezItMan reviewed Mar 2, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Time - Hannah J & Vera#8

Time - Hannah J & Vera#8
veralizeth wants to merge 11 commits intoAda-C13:masterfrom
veralizeth:master

veralizeth commented Feb 28, 2020 •

edited

Loading

Uh oh!

CheezItMan commented Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

CheezItMan Mar 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	return (total_rating / @trips.length).round(2)
	return (total_rating / @trips.length.to_f ).round(2)

		start_time: Time.parse(record[:start_time]),
		end_time: Time.parse(record[:end_time]),


		def request_trip(passenger_id)

		available_driver = find_frist_driver

	available_driver = find_frist_driver
	available_driver = find_first_driver

Conversation

veralizeth commented Feb 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Assignment Submission: OO Ride Share

Reflection

Uh oh!

CheezItMan commented Mar 2, 2020

OO Ride Share

Major Learning Goals/Code Review

Testing Requirements

Overall Feedback

Code Style Bonus Awards

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

veralizeth commented Feb 28, 2020 •

edited

Loading