Open
Conversation
…there is no clicking options
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
jmaddox19
reviewed
Apr 22, 2020
| const values = allMySquaresValues(); | ||
|
|
||
| } | ||
| const lines = [ |
| } | ||
| }; | ||
|
|
||
| const allMySquaresValues = () => { |
There was a problem hiding this comment.
I like that you pulled this out into a helper method!
Given that your solution lends itself to wanting to check the winner by looking at a 1-dimensional array, it would be an appropriate optimization to change the generateSquares function to just create a 1-D array from the beginning and use that as your state.
Truth be told, the main reason we set it up as a 2-D array is because we believed it would help many people with writing code to determine the winner.
But that's just an optimization! Not a significant problem with your code :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change. Speculate wildly about what the Big-O time complexity of that code might be.