Open
Conversation
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
SummaryVery well done, you hit all the learning goals here. Nice work! |
CheezItMan
reviewed
Apr 23, 2020
| // You will need to create a method to change the square | ||
| // When it is clicked on. | ||
| // Then pass it into the squares as a callback | ||
| const onClickCallback = (id) => { |
Comment on lines
+97
to
+98
| const arrayEquals = (one, two) => { | ||
| return JSON.stringify(one) === JSON.stringify(two); |
There was a problem hiding this comment.
I see you saw the post in Slack. nice!
Comment on lines
+103
to
+104
| window.location.reload(); | ||
| // found this on upmostly.com |
There was a problem hiding this comment.
That works, but you could also just do setSquares(generateSquares()); and set the player to player 1.
| const generateSquareComponents = (squares, onClickCallback) => { | ||
| // Complete this for Wave 1 | ||
|
|
||
| const squareBoxes = []; |
There was a problem hiding this comment.
This works, but you could also use the .flat function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.