Open
Conversation
React Tic Tac ToeMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
SummaryVery nicely done, the app works well and you got it deployed on Github pages! Sweet! You really demonstrated an understanding of state here and how to manage it in a React app. You met all the learning goals here. |
CheezItMan
reviewed
Apr 25, 2020
Comment on lines
31
to
+33
| const [squares, setSquares] = useState(generateSquares()); | ||
| const [currentPlayer, setCurrentPlayer] = useState(PLAYER_1); | ||
| const [currentWinner, setCurrentWinner] = useState(null); |
Comment on lines
+68
to
+73
| if (currentPlayer===PLAYER_1) { | ||
| setCurrentPlayer(PLAYER_2) | ||
| } | ||
| else { | ||
| setCurrentPlayer(PLAYER_1) | ||
| } |
There was a problem hiding this comment.
Just a suggestion
Suggested change
| if (currentPlayer===PLAYER_1) { | |
| setCurrentPlayer(PLAYER_2) | |
| } | |
| else { | |
| setCurrentPlayer(PLAYER_1) | |
| } | |
| const next_player = currentPlayer === PLAYER_1 ? PLAYER_2: Player_1 | |
| setCurrentPlayer(next_player) |
| } | ||
| }; | ||
|
|
||
| const checkForWinner = () => { |
| const isSquaresFilled = () => { | ||
| let isFilled = true; | ||
| //turn squares array from 2d to 1d:https://stackoverflow.com/questions/14824283/convert-a-2d-javascript-array-to-a-1d-array | ||
| let squaresflat = [].concat(...squares); |
There was a problem hiding this comment.
you can also do:
Suggested change
| let squaresflat = [].concat(...squares); | |
| let squaresflat = squares.flat() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.