Space - Diana

[dnguye2]

Assignment Submission: Ride Share

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Question	Answer
What did your data structure look like at first? Did this structure evolve over time? Why?	At first, it was a master array then 2 hashes. I changed it to a master hash > hash > values with arrays because it was easier for me to access any level of the data.
What was your strategy for going through the data structure and gathering information?	Figuring out how to get access to the question then the code to get the info for one single driver.
What was an example of something that was necessary to store in a variable? Why was it necessary, useful, or helpful?	When calculating the highest earner or highly rated, it was necessary to have a variable to iterate through the data. It was useful because creating the code to iterate through the data was easy to do an guided me on how to do it.
What kinds of iteration did you use? Did you use .map? If so, when? If not, why, or when would be a good opportunity to use it?	I used '.each' and '.map' . I used '.map' for the first three questions as it was slightly shorter and more intuitive for me than using '.each'.
Were some calculations easier than others? Why?	Yes, the first and second question was the easiest since it was fairly simple. For 3, it was harder because it involved figuring out multiple operations because it was an average while making sure to correctly access the data.

[dHelmgren]

Ride Share

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates, reads, and modifies variables	✔️
Correctly creates and accesses arrays	✔️
Correctly creates and accesses hashes	✔️
Reasonably organizes large amounts of related data into nested arrays and hashes	✔️
Correctly iterates through a nested data structure using loops and/or Enumerable methods	✔️
Reasonably organizes small pieces of code into methods, and calls/invokes those methods

Functional Requirements

Functional Requirement	yes/no
To the terminal, the program outputs the correct number of rides each driver has given	✔️
... outputs the total amount of money each driver has made	✔️
... outputs the average rating for each driver	✔️
... outputs which driver made the most money	✔️
... outputs which driver has the highest average rating	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	2-3 in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Elegant/Clever	✅

[dHelmgren]

If you are going to align these keys and values like this, indent these lines. It makes it more clear what is and isn't in each hash in rides

[dHelmgren]

this is pretty big for a standard comment! Can you sum it up in 1-2 lines instead? Comments work best as an in-line tool, snug with the code it's giving info on.

[dHelmgren]

This is SUPER elegant!

[dHelmgren]

Do you really want map here? What is map doing that each can't?

[dHelmgren]

You iterate over this hash a lot. Is there a way to keep this code organized while reducing the number of times you loop over rides? Perhaps methods could help.