Open
Conversation
Ride ShareMajor Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
CheezItMan
reviewed
Feb 14, 2020
| end | ||
|
|
||
| # ride information copied from the rides.csv file, organized as an array of hashes, where each hash represents one ride | ||
| rides = [ |
| @@ -0,0 +1,138 @@ | |||
| # a method to add a driver to the driver hash | |||
| def add_driver_to_hash(ride_hash, drivers_hash) | |||
| drivers_hash[ride_hash[:driver_id]] = { | |||
There was a problem hiding this comment.
So any driver you add this this won't have any rides listed, but will have a cost and total of ratings?
| # initiliaze the new drivers hash where information per driver will be stored | ||
| drivers = {} | ||
|
|
||
| # loop through the rides array of hashes |
There was a problem hiding this comment.
Some of these segments could be broken into methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Ride Share
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
.map? If so, when? If not, why, or when would be a good opportunity to use it?