Open
Conversation
CheezItMan
reviewed
Apr 28, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Jing, you mostly hit the learning goals with one test in kth elements not passing. The code is very clean and readable. Just the one issue.
Comment on lines
26
to
30
| # This method will return the k most common elements | ||
| # in the case of a tie it will select the first occuring element. | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def top_k_frequent_elements(list, k) |
There was a problem hiding this comment.
This mostly works, but it doesn't pass all the tests because it doesn't select the 1st element which appears the most times, in case of a tie.
Comment on lines
+4
to
7
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| def grouped_anagrams(strings) |
There was a problem hiding this comment.
👍 Interesting use of a hash as a key for a hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions