Open
Conversation
CheezItMan
reviewed
Apr 28, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Great work Kim! You hit the learning goals and even got the bonus. Well done. I had a few minor comments, but this is great.
Comment on lines
+4
to
6
| # Time Complexity: O(n) where n is the number of chars | ||
| # Space Complexity: O(n) where n is the number of words | ||
| def grouped_anagrams(strings) |
There was a problem hiding this comment.
👍 Interesting solution, the time complexity is O(n) if the words are pretty short, if they're unlimited in length the time complexity is O(nm) where m is the length of the longest string.
Comment on lines
+24
to
26
| # Time Complexity: O(n log n) | ||
| # Space Complexity: O(n) | ||
| def top_k_frequent_elements(list, k) |
Comment on lines
+57
to
59
| # Time Complexity: O(1) | ||
| # Space Complexity: O(n) | ||
| def valid_sudoku(table) |
There was a problem hiding this comment.
👍 I would say the time/space complexities are both O(1) since Sudoku never gets bigger than 9x9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions