forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 37
Fire - Aimee & Roshni #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
roshni-patel
wants to merge
26
commits into
Ada-C14:master
Choose a base branch
from
roshni-patel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b306084
ran npm install and start to see local host
marks214 d2fe50a
Update tests to reflect requirements for waves
roshni-patel 37a19d1
Merge branch 'master' into wave1
marks214 a8e41ee
added the onButtonClick arrow function to enable the Square component…
marks214 7a33d12
generateSquareComponents returns a 1D array of square components
marks214 2384636
psuedo code for wave 2
marks214 bc9b397
Merge pull request #1 from roshni-patel/wave1
roshni-patel 115be3d
Merge branch 'master' into AAO/wave2
marks214 a4952ef
more psuedo code, from watching Devin's nested events video
marks214 be2a0f5
first x appears
marks214 00e5456
changed conditional logic, switching player turns is now working
marks214 f7e5064
Fixed a few failing tests
roshni-patel 2d716ec
Merge pull request #2 from roshni-patel/AAO/wave2
roshni-patel ca017f9
minor changes, removed comments/changed syntax/style
marks214 331a54e
Merge branch 'master' into AAO/wave2
marks214 d6321ec
added psuedocode to check for wins
marks214 2d86b3e
Merge pull request #3 from roshni-patel/AAO/wave2
roshni-patel 216739c
set winner is not working
marks214 631bd6b
check winner is now working, game stops when a winner is declared
marks214 efc759e
tests unskipped and passing for wave 3 - checks winner
marks214 1b3c666
Merge pull request #4 from roshni-patel/AAO/wave3
roshni-patel 02feaea
reset game is working
marks214 9c8dab4
displays current player and correct winner
marks214 6eef0a0
added code to handle ties - used conditional rendering
marks214 a19a5d8
Merge pull request #5 from roshni-patel/wave4
marks214 bffcf6a
Unskipped a test
roshni-patel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh, snazzy
winCombosarray!