forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 37
Water/Earth - Beatrice/Emily #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emirry
wants to merge
14
commits into
Ada-C14:master
Choose a base branch
from
emirry:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5e6e841
Updated tests to have tests in correct descrive blocks per Jared
Beatress e9458f7
square.js wave 1 implemented.all tests pass
emirry 55be574
Merge branch 'master' of https://github.com/emirry/react-tic-tac-toe
emirry c6a3f35
Board.js wave 1 brainstrom
emirry c0181fb
Finished wave 1, squares render
Beatress f1090cb
began wave 2
emirry 956895e
Added onClickCallback function pseudocode
Beatress a123465
Moved square state up to App, App keeps track of current player
Beatress 017622d
onClickCallback implemented. tic tac toe board can update, but all te…
emirry 1a5f838
Fixed player not changing when duplicate square clicked on
Beatress ae6aafb
Changed capitalization of tests, wave 2 done
Beatress d225ae8
Added checkForWinner() and checkForTies(), need to fix some bugs
Beatress c38fa9c
Wave 3-can announce winner or tie
emirry 323a914
Fixed bug with finding a winner - ignored blank squares
Beatress File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work implementing this algorithm with a 2D array.