Hanh Solo & Madeline

[made-line]

Assignment Submission: Video Store API

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Reflection

Prompt	Response
Explain how you came up with the initial design of your ERD, based on the seed data and reading through the API endpoints	For our ERD, we made three entities based off the seed data and endpoints: videos, rentals, and customers. Videos have many rentals and customers. Rentals belong to customers and videos. Customers have many videos and rentals.
What would be the Big-O time complexity of your /customers & /videos endpoints? What does the time complexity depend on? Explain your reasoning.	The GET /customers and GET /videos endpoints have a time complexity of O(n) because every entry in the database is looked at once. The GET /video/:id endpoint has a time complexity of O(1) because it's a one-step operation of finding the database entry by the ID. The POST /videos endpoint is O(1) because it's a one-step operation of creating one video.
What is the Big-O time complexity of the POST /rentals/check-in endpoint? What does the time complexity depend on? Explain your reasoning.	N/A
Describe a specific set of positive and negative test cases you implemented for a model.	We wrote a positive test to ensure a video is valid with all the required attributes. We wrote negative test cases to ensure a video is invalid if it's missing any of the required fields.
Describe a specific set of positive and negative test cases you implemented for a controller.	In the Videos controller, a positive test case we wrote is that it must get the index. A negative test case is that it gets the index even with no videos.
Broadly, describe how an API should respond when it handles a request with invalid/erroneous parameters.	It should respond with an error message that describes why the error occurred. It should also include a bad_request response code.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	N/A

[dHelmgren]

Video Store API

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices git with at least 10 small commits and meaningful commit messages	✔️
Understands the importance of how APIs handle invalid/erroneous data in their reflection questions	✔️
Practices Rails best practices and well-designed separation, and encapsulates business logic around check-out and check-in in models
Uses controller tests to ensure quality code for every route, and checks for response status and content, with positive cases and negative cases
Uses controller tests to ensure correctness for check out and check in requirement, and that checked out counts and inventories appropriately change

Functional Requirements

Functional Requirement	yes/no
All provided smoke tests for Wave 1 pass	✔️
All provided smoke tests for Wave 2 pass

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	3+ in Code Review && 2 in Functional Requirements
Yellow (Approaches Standards)	2+ in Code Review && 1+ in Functional Requirements, or the instructor judges that this project needs special attention	✔️
Red (Not at Standard)	0-1 in Code Review or 0 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention