Kayla & Marj by Schmarj3 · Pull Request #29 · Ada-C14/video-store-api

Schmarj3 · 2020-12-04T19:41:32Z

Assignment Submission: Video Store API

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Reflection

Prompt	Response
Explain how you came up with the initial design of your ERD, based on the seed data and reading through the API endpoints	We saw that there were customers and videos that needed to connect through rentals.
What would be the Big-O time complexity of your `/customers` & `/videos` endpoints? What does the time complexity depend on? Explain your reasoning.	We think it will take O(n) to loop through all customers or videos then O(n) to print them all out as json. When the endpoint requires specific information like an id, we think it might be O(1) because the address needed known.
What is the Big-O time complexity of the `POST /rentals/check-in` endpoint? What does the time complexity depend on? Explain your reasoning.	Since both checkin and checkout require the customer_id and video_id, it's easier to look the information up quickly, so O(1). Then updating the database should also take just O(1).
Describe a specific set of positive and negative test cases you implemented for a model.	If did, would would have created a validation test for the video model to make sure there was at least a title present.
Describe a specific set of positive and negative test cases you implemented for a controller.	"increase the customer videos_checked_out_count by one" as the positive test case, and "return back detailed errors and a status 404: Not Found if the customer does not exist" as the negative test case.
Broadly, describe how an API should respond when it handles a request with invalid/erroneous parameters.	should respond with a 404 or invalid request error message and status ok is false.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We tried to create a custom method for the checkout due date, but kept receiving a no method error.

initial commit, generated models and controllers, routes

Created migrations for video and customer tables to change datatypes

Relationships and validations

…into master

changed and fixed schema columns in order to seed data

modified returned json data for customer

Get video show

Post video create

changed the error values in the show method

Rental controller

Removed some validations for video

CheezItMan

Video Store API

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices git with at least 10 small commits and meaningful commit messages	✔️
Understands the importance of how APIs handle invalid/erroneous data in their reflection questions	✔️
Practices Rails best practices and well-designed separation, and encapsulates business logic around check-out and check-in in models	⚠️ No business logic methods
Uses controller tests to ensure quality code for every route, and checks for response status and content, with positive cases and negative cases	⚠️ Looks like you had ideas on what to write for wave 2, you got wave 1 in.
Uses controller tests to ensure correctness for `check out` and `check in` requirement, and that checked out counts and inventories appropriately change	⚠️ You got started on this, but it didn't look like it was finished.

Functional Requirements

Functional Requirement	yes/no
All provided smoke tests for Wave 1 pass	✔️, Except for the error reporting because you're missing validations.
All provided smoke tests for Wave 2 pass	⚠️ NA

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	3+ in Code Review && 2 in Functional Requirements	💚

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Descriptive/Readable	✅
Logical/Organized	✅

Summary

This is probably a yellowish green submission due to the failing tests for creating a video. Take a look at my comments, but the main issues are missing validations, and limited tests for the additional parts you wrote.

That said you demonstrated you know how to recieve an API request and respond with JSON and the proper status code.

CheezItMan · 2020-12-09T03:40:28Z

config/routes.rb

+  resources :customers, only: [:index, :show]
+  resources :videos, only: [:index, :show, :create]
+  # resources :rentals, only: [:index, :show]
+  post '/rentals/checkout', to: "rentals#checkout", as: 'checkout'


No route for check-in?

CheezItMan · 2020-12-09T03:40:34Z

config/routes.rb

+  resources :customers, only: [:index, :show]
+  resources :videos, only: [:index, :show, :create]


CheezItMan · 2020-12-09T03:40:55Z

app/models/customer.rb

@@ -0,0 +1,4 @@
+class Customer < ApplicationRecord


No validations?

CheezItMan · 2020-12-09T03:41:05Z

app/models/rental.rb

+  def calculate_due_date(checkout_date, days_due)
+    date = checkout_date + (60 * 60 * 24 * days_due)
+    return date.strftime('%Y-%m-%d')
+  end


CheezItMan · 2020-12-09T03:41:17Z

app/models/video.rb

+  has_many :rentals
+  has_many :customers, through: :rentals
+
+  validates :title, presence: true


Only this validation?

CheezItMan · 2020-12-09T03:49:46Z

test/models/rental_test.rb

@@ -0,0 +1,7 @@
+require "test_helper"
+
+describe Rental do


Noting no tests

CheezItMan · 2020-12-09T03:49:55Z

test/models/video_test.rb

@@ -0,0 +1,7 @@
+require "test_helper"
+
+describe Video do


Noting no tests

CheezItMan · 2020-12-09T03:50:22Z

test/controllers/rentals_controller_test.rb

+    it "decrease the video's available_inventory by one" do
+
+    end
+
+    it 'should create a due date, 7 days from checkout date' do
+
+    end


Missing some tests

CheezItMan · 2020-12-09T03:52:19Z

test/controllers/rentals_controller_test.rb

+    it 'return back detailed errors and a status 400: Bad Request if the video does not have any available inventory before check out ' do
+
+    end


Good that you knew you needed this test.

CheezItMan · 2020-12-09T03:52:52Z

test/controllers/rentals_controller_test.rb

+    end
+  end
+
+  describe "rental check-in" do


These would be the things you need to test.

Schmarj3 and others added 30 commits December 1, 2020 18:04

initial commit, generated models and controllers, routes

9c712d8

Merge pull request #1 from Schmarj3/model_controller_generate

dfac2b7

initial commit, generated models and controllers, routes

Created migrations for video and customer tables to change datatypes

18e6a8c

Merge pull request #2 from Schmarj3/migration_branch

52b430d

Created migrations for video and customer tables to change datatypes

added relationships between our three models

be5d165

Added /tmp to gitignore

347340e

Added gitignore

dd7445c

Merge pull request #3 from Schmarj3/relationships_and_validations

df0c8b0

Relationships and validations

Cleaned up ignored files

6fb35c8

Removed /tmp from gitignore

30f6643

Deleted temp folder

f691af4

Added tmp to gitignore

ec770cf

Deleted

4d01e3d

Merge branch 'master' of https://github.com/Schmarj3/video-store-api …

2ddd64e

…into master

delete

08ad858

recovered original .gitignore file

722fbc2

gitignore

8e32f43

redid gitignore

3f779bd

rmoved log

76c5989

lakdf

ea08ad3

adkf

49df12b

changed and fixed schema columns in order to seed data

8c523b4

Merge pull request #4 from Schmarj3/customer_controller

e68ee0a

changed and fixed schema columns in order to seed data

modified returned json data for customer

1376f8a

added index method to 'GET' videos--tests passing

e1ff66d

Completed get show, changed one test for date

bf9b831

Merge pull request #7 from Schmarj3/customer_controller

e77f32c

modified returned json data for customer

Merge pull request #5 from Schmarj3/get_video_show

74e09a1

Get video show

added video create method and strong params to controller

f4162f3

Added validation to Video model

ed9066d

Schmarj3 and others added 13 commits December 2, 2020 17:09

Merge pull request #8 from Schmarj3/post_video_create

e167521

Post video create

changed the error values in the show method

387acf1

Merge pull request #9 from Schmarj3/error_messages

52a4bda

changed the error values in the show method

added ds store to gitignore

1a5ca7f

added error message format change

06c7038

postman tests for wave 1 passing

6eaf7bf

Removed some validations for video

89d1b09

started TDD for rental controller

44e0ffd

added some tests for rental controller

654cfef

added checkout route method and ran written tests

68033cd

Merge pull request #10 from Schmarj3/rental_controller

7c44f72

Rental controller

Merge pull request #11 from Schmarj3/video_validations

cd832ba

Removed some validations for video

final commit, added comments to explain commented code

8153670

CheezItMan reviewed Dec 9, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kayla & Marj#29

Kayla & Marj#29
Schmarj3 wants to merge 43 commits intoAda-C14:masterfrom
schmarj3-learning-projects:master

Schmarj3 commented Dec 4, 2020

Uh oh!

CheezItMan left a comment

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

CheezItMan Dec 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

		resources :customers, only: [:index, :show]
		resources :videos, only: [:index, :show, :create]

		it 'return back detailed errors and a status 400: Bad Request if the video does not have any available inventory before check out ' do

		end

Conversation

Schmarj3 commented Dec 4, 2020

Assignment Submission: Video Store API

Reflection

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Video Store API

Major Learning Goals/Code Review

Functional Requirements

Overall Feedback

Code Style Bonus Awards

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments