Open
Conversation
CheezItMan
reviewed
Dec 9, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Video Store API
Major Learning Goals/Code Review
| Criteria | yes/no, and optionally any details/lines of code to reference |
|---|---|
| Practices git with at least 10 small commits and meaningful commit messages | ✔️ |
| Understands the importance of how APIs handle invalid/erroneous data in their reflection questions | ✔️ |
| Practices Rails best practices and well-designed separation, and encapsulates business logic around check-out and check-in in models | ✔️, although you should move more check-in check-out business logic into the models. |
| Uses controller tests to ensure quality code for every route, and checks for response status and content, with positive cases and negative cases | ✔️ |
Uses controller tests to ensure correctness for check out and check in requirement, and that checked out counts and inventories appropriately change |
✔️ |
Functional Requirements
| Functional Requirement | yes/no |
|---|---|
| All provided smoke tests for Wave 1 pass | ✔️ |
| All provided smoke tests for Wave 2 pass | ✔️ |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 3+ in Code Review && 2 in Functional Requirements | 💚 |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Elegant/Clever | ✅ |
| Descriptive/Readable | ✅ |
| Logical/Organized | ✅ |
Summary
Nice work, you both hit the learning goals here. I do like your tests a lot. Well done.
Comment on lines
+4
to
+8
| resources :customers, only: [:index] | ||
| resources :videos, only: [:index, :show, :create] | ||
|
|
||
| post '/rentals/check-out', to: 'rentals#check_out', as: "check_out" | ||
| post '/rentals/check-in', to: 'rentals#check_in', as: "check_in" |
| @@ -0,0 +1,13 @@ | |||
| class Video < ApplicationRecord | |||
There was a problem hiding this comment.
It would make sense to have a checkout_video method instead of doing that logic in the controller.
Comment on lines
+8
to
+10
| def show | ||
|
|
||
| end |
| before_action :find_customer | ||
| before_action :find_video | ||
|
|
||
| def check_out |
There was a problem hiding this comment.
These methods are a bit long, maybe creating a check-out and check-in methods for the model-level.
Comment on lines
+3
to
+4
| before_action :find_customer | ||
| before_action :find_video |
| end | ||
| end | ||
|
|
||
| describe "validations" do |
| expect(found_rental.video.available_inventory).must_equal start_inventory_count - 1 | ||
| expect(end_count).must_equal start_inventory_count - 1 | ||
| end | ||
| # TODO: negative or edge test case? |
There was a problem hiding this comment.
Well at least you're noteing this. No test to make sure the inventory can't go below 0
| # TODO: negative or edge test case? | ||
| end | ||
|
|
||
| describe "increase_videos_checked_out" do |
There was a problem hiding this comment.
What about a test to see if more videos can be checked out than you have in inventory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Video Store API
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.
Reflection
/customers&/videosendpoints? What does the time complexity depend on? Explain your reasoning.POST /rentals/check-inendpoint? What does the time complexity depend on? Explain your reasoning.