Open
Conversation
kyra-patton
reviewed
Jul 19, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
✨🐩 Nice work, Faith. I left a couple comments on time complexity and edge cases, but overall a very clean BFS solution. Let me know what questions you have.
🟢
| into the same partition. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(n) |
There was a problem hiding this comment.
⏱ Time complexity will actually be O(N + E) where N is the number of nodes/dogs in dislikes and E is the number of edges or dislikes between two dogs. You loop through all of the nodes, then each of the nodes' edges.
Comment on lines
+23
to
+26
| if dislikes[0]: | ||
| start = 0 | ||
| else: | ||
| start = 1 |
There was a problem hiding this comment.
What if there are multiple dogs at the beginning of dislikes that don't dislike any other dogs (are disconnected from the rest of the graph)? How might you account for this edge case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.