Open
Conversation
kyra-patton
reviewed
Jul 19, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
🐶🐾 Nice work, Alma. Overall it looks like a solid BFS implementation, I just left a few comments and suggestions. Let me know what questions you have.
🟢
Comment on lines
+8
to
+9
| Time Complexity: O(V + E) | ||
| Space Complexity: O(n) |
There was a problem hiding this comment.
✨ Correct for a breadth first search implementation, but I would suggest you define your variables particularly because you use different variables to represent the same thing here. V and n both represent the number of vertices/nodes and E represents the number of edges.
Comment on lines
+19
to
+24
| for i in range(len(dislikes)): | ||
| if dislikes[i]: | ||
| first_dog = i | ||
| break | ||
| if first_dog == None: | ||
| return True |
There was a problem hiding this comment.
Could you refactor this to avoid a break statement? Perhaps use a while loop?
Comment on lines
+26
to
+27
| groups[first_dog] = first_group | ||
| groups[first_dog] = True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.