Open
Conversation
kyra-patton
reviewed
Jul 25, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
🐶🐾 Nice work, Rhyannon. It looks like you've got a good understanding of BFS, including the time complexity. Let me know what questions you have.
🟢
Comment on lines
+8
to
+11
| Time Complexity: Generally Linear O(N), but more specifically | ||
| O(N+E) or O(V+E), in which E is edges & V for vertices, | ||
| Space Complexity: We're initializing 3 new data structures -> | ||
| performance depends on the length of these sets, Linear O(N) |
There was a problem hiding this comment.
💫🦴 Thanks for defining your variables and constraints!
Comment on lines
+22
to
+25
| if dislikes[0]: | ||
| start_node = 0 | ||
| else: | ||
| start_node = 1 |
There was a problem hiding this comment.
🤔 Consider a case where the graph has multiple nodes disconnected and they are all indexed at the beginning of the adjacency list dislikes. For example:
dislikes = [ [], [], [], [4, 5], [5,1], [3]]. How might you refactor your code to account for this edge case?
| visited.add(start_node) | ||
| red.add(start_node) | ||
|
|
||
| while len(queue) != 0: |
There was a problem hiding this comment.
💫🐩 Really clear BFS solution nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asked another student for help