Open
Conversation
kyra-patton
reviewed
Jun 14, 2022
kyra-patton
left a comment
kyra-patton
left a comment
There was a problem hiding this comment.
✨🌸 Very nice work Kristin. I left some suggestions as to how you might simplify your stacks implementation, but your stack and queue look solid. Let me know what questions you have.
🟢
| returns None | ||
| """ | ||
| pass | ||
| if self.size == self.buffer_size: |
| self.rear = (self.rear + 1) % self.buffer_size | ||
| self.size += 1 | ||
|
|
||
| def dequeue(self): |
|
|
||
| return front | ||
|
|
||
| def front(self): |
| return self.front | ||
|
|
||
|
|
||
| def size(self): |
| pass | ||
| return self.size | ||
|
|
||
| def empty(self): |
| return True | ||
| return False | ||
|
|
||
| def __str__(self): |
| """ | ||
| pass | ||
|
|
||
| self.store.add_last(element) |
| # self.store.tail = element | ||
|
|
||
| def pop(self): | ||
| """ Removes an element from the top |
There was a problem hiding this comment.
✨ This will work, however you could also take advantage of the remove_last method in the LinkedList class
|
|
||
|
|
||
|
|
||
| def empty(self): |
There was a problem hiding this comment.
✨ Again, this will work, however you could take advantage of LinkedList's empty method
| return False | ||
|
|
||
|
|
||
| def __str__(self): |
There was a problem hiding this comment.
😎 Again, this works, but take a look at LinkedList's str method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation