C16 - Spruce - Vange Spracklin by HouseOfVange · Pull Request #46 · Ada-C16/stacks-queues

HouseOfVange · 2022-07-17T01:03:50Z

Stacks and Queues

Thanks for doing some brain yoga. You are now submitting this assignment!

Comprehension Questions

Question	Answer
What is an ADT?
Describe a Stack
What are the 5 methods in Stack and what does each do?
Describe a Queue
What are the 5 methods in Queue and what does each do?
What is the difference between implementing something and using something?

OPTIONAL JobSimulation

Question	Answer
Did you include a sample run of your code as a comment?

kyra-patton

✨😎 Very nice work, Vange! I left a couple small suggestions, but overall your implementation is solid.

I am grading this as a yellow because you did not attempt the comprehension questions, but a yellow is a passing score. If you would like to resubmit with the comprehension questions filled in, I'd happily up this to a green!

🟡

kyra-patton · 2022-07-19T16:33:58Z

stacks_queues/queue.py

-      
+

    def enqueue(self, element):


kyra-patton · 2022-07-19T16:34:17Z

stacks_queues/queue.py

+        self.rear = (self.rear + 1) % self.buffer_size
+        self.size += 1

    def dequeue(self):


kyra-patton · 2022-07-19T16:49:25Z

stacks_queues/queue.py

        """
        pass
+        if self.size == 0:
+            None


🤔 Looks like you forgot to return here. As it stands, you basically state the name of a literal None and then it floats away into the ether ☁

Suggested change

None

return None

kyra-patton · 2022-07-19T16:49:51Z

stacks_queues/queue.py

+        return self.store[self.front]


    def size(self):


kyra-patton · 2022-07-19T16:50:00Z

stacks_queues/queue.py

-        pass
+        return self.size

    def empty(self):


kyra-patton · 2022-07-19T16:51:23Z

stacks_queues/stack.py

            Returns None
        """
-        pass
+        self.store.add_last(element)


kyra-patton · 2022-07-19T16:52:30Z

stacks_queues/stack.py

        """
-        pass
+        self.store.add_last(element)
+        return None


Small style tip: If a function always returns None, I'd recommend returning None implicitly by just not having any return value (functions in Python return None by default).

Suggested change

return None

kyra-patton · 2022-07-19T16:52:45Z

stacks_queues/stack.py

+        return None

    def pop(self):
        """ Removes an element from the top


kyra-patton · 2022-07-19T16:53:00Z

stacks_queues/stack.py

+        return self.store.remove_last()
+        # return None

    def empty(self):


kyra-patton · 2022-07-19T16:53:28Z

stacks_queues/stack.py

            ending with the bottom of the Stack.
        """
-        pass
+        if self.empty:


✨ Nice! You could also take advantage of LinkedList's str method!

HouseOfVange added 3 commits July 16, 2022 17:29

solves queue probs

e8041a0

cleans up linked list formatting

7bfcd9d

solves stack probs

9ad35c1

kyra-patton reviewed Jul 19, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C16 - Spruce - Vange Spracklin#46

C16 - Spruce - Vange Spracklin#46
HouseOfVange wants to merge 3 commits intoAda-C16:masterfrom
HouseOfVange:master

HouseOfVange commented Jul 17, 2022

Uh oh!

kyra-patton left a comment

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

kyra-patton Jul 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HouseOfVange commented Jul 17, 2022

Stacks and Queues

Comprehension Questions

OPTIONAL JobSimulation

Uh oh!

kyra-patton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants