Maple - Min by Eatmine · Pull Request #97 · Ada-C16/viewing-party

Eatmine · 2021-09-17T23:35:24Z

No description provided.

tgoslee · 2021-09-19T23:48:43Z

viewing_party/party.py

@@ -0,0 +1,259 @@
+#Wave_One part 1 
+def create_movie (title, genre, rating):


tgoslee · 2021-09-19T23:48:56Z

viewing_party/party.py

+        return None
+
+#Wave_One part 2 
+def add_to_watched(user_data, movie): 


tgoslee · 2021-09-19T23:49:05Z

viewing_party/party.py

+
+#Wave_One part 3 
+
+def add_to_watchlist(user_data, movie):


tgoslee · 2021-09-19T23:51:51Z

viewing_party/party.py

+        if movie["title"] == title:
+
+            user_data["watched"].append(movie)
+            user_data["watchlist"].remove(movie)


even though remove works great here, be careful using it in a for loop. It can cause side effects. Here is a link that explains it more with examples https://thispointer.com/python-remove-elements-from-a-list-while-iterating/

tgoslee · 2021-09-19T23:53:31Z

viewing_party/party.py

+
+

remove extra spacing

tgoslee · 2021-09-19T23:53:45Z

viewing_party/party.py

+
+#Wave_TWO Part 1 
+
+def get_watched_avg_rating(user_data):


great implementation!

tgoslee · 2021-09-19T23:54:13Z

viewing_party/party.py

+            if "genre" in movie_genre:
+                most_populare_genre.append(movie_genre["genre"])
+            most_common = max(most_populare_genre, key = most_populare_genre.count)
+            print (most_common)


remove print statement from debugging

tgoslee · 2021-09-19T23:55:17Z

viewing_party/party.py

+#Completed using a dict but wasn't my first choice
+# def get_most_watched_genre(user_data):
+#     most_popular_genre = {}
+#     if len(user_data["watched"]) == 0:
+#         return None
+#     for movie_genre in user_data["watched"]:
+#         if movie_genre ["genre"] in most_popular_genre:
+#             most_popular_genre[movie_genre["genre"]] += 1
+
+#         else:
+#             most_popular_genre[movie_genre["genre"]] = 1
+
+#     max_value_genre=max(most_popular_genre, key= most_popular_genre.get)
+#     return max_value_genre
+
+#     # https://www.programiz.com/python-programming/methods/built-in/max


if this isn't the way you want to implement it then you can remove this commented code

tgoslee · 2021-09-19T23:55:39Z

viewing_party/party.py

+    friend_movie_set = set()
+    for movie in user_watched: 
+        user_movie_set.add(movie["title"])
+        print(user_movie_set)


remove print

tgoslee · 2021-09-19T23:56:04Z

viewing_party/party.py

+
+#Wave_Three Part 1 
+
+def get_unique_watched(user_data):


Nice use of sets

tgoslee · 2021-09-19T23:56:18Z

viewing_party/party.py

+    friend_movie_set = set()
+    for movie in user_watched: 
+        user_movie_set.add(movie["title"])
+        print(user_movie_set)


remove print

tgoslee · 2021-09-19T23:56:54Z

viewing_party/party.py

+
+def get_available_recs(user_data):
+    users_subscription = user_data["subscriptions"]
+    friends_unique_movies = get_friends_unique_watched(user_data) 


great use of helper function

tgoslee · 2021-09-19T23:57:04Z

viewing_party/party.py

+    for movies_watched in friends_movie_list:
+        if movies_watched["host"] in users_subscription and movies_watched not in movie_subscription:
+            movie_subscription.append(movies_watched)
+    print(movie_subscription)


remove print

tgoslee · 2021-09-20T00:02:07Z

viewing_party/party.py

+
+
+
+def get_available_recs(user_data):


This is a good implementation. I want to offer a suggestion that uses fewer lines of code.

def get_available_recs(user_data): recommended_movies = [] friends_unique_watched = get_friends_unique_watched(user_data) for movie in friends_unique_watched: if movie["host"] in user_data["subscriptions"]: recommended_movies.append(movie) return recommended_movies

tgoslee · 2021-09-20T00:03:44Z

viewing_party/party.py

+def get_available_recs(user_data):
+    users_subscription = user_data["subscriptions"]
+    friends_unique_movies = get_friends_unique_watched(user_data) 
+    users_friends = user_data["friends"]
+    users_friends_watched_movie = user_data["friends"]
+
+
+    friends_movie_list = []
+    for watched_movies in users_friends:
+
+
+        for movies in watched_movies["watched"]:
+            friends_movie_list.append(movies)
+
+    movie_subscription = []
+    for movies_watched in friends_movie_list:
+        if movies_watched["host"] in users_subscription and movies_watched not in movie_subscription:
+            movie_subscription.append(movies_watched)
+    print(movie_subscription)
+
+
+    user_title =[]
+    for watched_movie in user_data["watched"]:
+        user_title.append(watched_movie["title"])
+
+
+    recommendations =[]
+
+    if not user_data["watched"]:
+        return movie_subscription
+    for movie in movie_subscription:
+        if movie["title"] not in user_title:
+            recommendations.append(movie)
+    return recommendations


This is a good implementation but I wanted to offer a solution that uses less lines of code

Suggested change

def get_available_recs(user_data):

users_subscription = user_data["subscriptions"]

friends_unique_movies = get_friends_unique_watched(user_data)

users_friends = user_data["friends"]

users_friends_watched_movie = user_data["friends"]

friends_movie_list = []

for watched_movies in users_friends:

for movies in watched_movies["watched"]:

friends_movie_list.append(movies)

movie_subscription = []

for movies_watched in friends_movie_list:

if movies_watched["host"] in users_subscription and movies_watched not in movie_subscription:

movie_subscription.append(movies_watched)

print(movie_subscription)

user_title =[]

for watched_movie in user_data["watched"]:

user_title.append(watched_movie["title"])

recommendations =[]

if not user_data["watched"]:

return movie_subscription

for movie in movie_subscription:

if movie["title"] not in user_title:

recommendations.append(movie)

return recommendations

def get_available_recs(user_data):

recommended_movies = []

friends_unique_watched = get_friends_unique_watched(user_data)

for movie in friends_unique_watched:

if movie["host"] in user_data["subscriptions"]:

recommended_movies.append(movie)

return recommended_movies

tgoslee · 2021-09-20T00:06:36Z

viewing_party/party.py

+#Wave 5 Part 1
+
+
+def get_new_rec_by_genre(user_data):


Good implementation and use of helper functions. How could you also use get_friends_unique_watched(user_data)?

tgoslee · 2021-09-20T00:07:35Z

viewing_party/party.py

+    #             for friends in users_friends: # {'watched': [{'title': 'Title A', 'host': 'Service A'}, {'title': 'Title C', 'host': 'Service C'}]}
+    #                 for friends in (friends["watched"]): #{'title': 'Title A', 'host': 'Service A'} --> friends_movies 
+    #                             if movie["host"] and  movie["title"]:
+    #                                         friends_movie_list.append(movie["watched"])
+    # #                                             print(m)
+    # # print(friends_movie_list)
+    # return friends_movie_list
+
+
+
+
+
+    # users_movie = user_data["watched"]
+    # users_friends = user_data["friends"]
+    # users_subscription = user_data["subscriptions"]
+    # recommended_movie_list = []
+    # friends_movies_list = []
+    # friends_movies_list1 = []
+    # final_recommendations = []


remove code once you are done testing/debugging

tgoslee · 2021-09-20T00:08:05Z

viewing_party/party.py

+
+
+#wave 5 Part 2
+def get_rec_from_favorites(user_data):


what helper functions could you also use here?

tgoslee · 2021-09-20T00:09:24Z

Great job! I like how you thought through alternative ways to approach the functions. I added comments on refactoring your code, removing unused code, and the use of the helper functions.

Eatmine added 5 commits September 14, 2021 08:49

First Wave Complete

213dbac

First wave complete

b80b924

almost complete

9cd6d5a

partiaally complete

1a74ca4

Final Project, passed all functions in test

3d6615c