Min Weather Report App#70
Open
Eatmine wants to merge 5 commits intoAda-C16:mainfrom
Open
Conversation
tgoslee
reviewed
Dec 21, 2021
| <h2 id=gardenText></h2> | ||
|
|
||
| </div> | ||
| <br> |
There was a problem hiding this comment.
instead of using a br you could add margins to your divs to create space
tgoslee
reviewed
Dec 21, 2021
Comment on lines
+70
to
+73
| <!-- ‼️❗️🤯😳☀️😎 🌆🌇🎇🥵💃🏾💋‼️❗️🤯 --> | ||
| <!-- 🥶🧊💎🥶🧊💎🥶🧊💎🥶🧊💎🥶🧊💎🥶🧊💎🥶🧊💎🥶🧊💎🥶🧊💎🥶 | ||
| ✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️✌🏾✈️☁️ | ||
| 🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂🌧☔️🌂 --> No newline at end of file |
There was a problem hiding this comment.
I would remove these emojis in your HTML file because you are using them in your JS file.
tgoslee
reviewed
Dec 21, 2021
| @@ -0,0 +1,139 @@ | |||
| console.log("loaded") | |||
tgoslee
reviewed
Dec 22, 2021
| state.tempchange += 1; | ||
| const increseButtonElement = document.getElementById('tempvalue'); | ||
| increseButtonElement.textContent = `${state.tempchange}`; | ||
| console.log("clickly click click"); |
tgoslee
reviewed
Dec 22, 2021
| state.tempchange -= 1; | ||
| const decreaseButtonElement = document.getElementById('tempvalue'); | ||
| decreaseButtonElement.textContent = `${state.tempchange}`; | ||
| console.log("downbutton click") |
tgoslee
reviewed
Dec 22, 2021
Comment on lines
+27
to
+39
| // let gardenGifs = "cloudy"; | ||
|
|
||
| // if (inputSky === "cloudy") { | ||
| // gardenGifs = "cloudy" | ||
|
|
||
| // } else if (inputSky === "sunny") { | ||
| // gardenGifs = "sunny"; | ||
| // } else if (inputSky === "rainy") { | ||
| // gardenGifs = "rainy"; | ||
| // } else if (inputSky === "snowy") { | ||
| // gardenGifs = "snowy"; | ||
| // } | ||
|
|
tgoslee
reviewed
Dec 22, 2021
| const cityNameInputEl= document.getElementById("cityNameInput").value; | ||
| const headerCityEl = document.getElementById("CityName"); | ||
| headerCityEl.textContent = cityNameInputEl; | ||
| console.log("citygirls") |
tgoslee
reviewed
Dec 22, 2021
Comment on lines
+65
to
+78
| const tempColor = document.getElementById("tempvalue"); | ||
| let color = "blue"; | ||
| if (state.tempchange >=80){ | ||
| color = "rgba(24, 17, 24, 0.836)"; | ||
| console.log("hotttttttttt") | ||
| }else if (state.tempchange >=70){ | ||
| color = "rgb(117, 87, 117)"; | ||
| }else if (state.tempchange >=60){ | ||
| color = "rgb(175, 124, 175)"; | ||
| }else if (state.tempchange >=50){ | ||
| color = "black"; | ||
| } | ||
| tempColor.classList = color; | ||
|
|
There was a problem hiding this comment.
in css you need to add properties for each of the colors and then the value you want. For example, if color = "black" then in CSS you should have
.black {
color: black;
}
tgoslee
reviewed
Dec 22, 2021
|
|
||
| </div> | ||
| <br> | ||
| <div class = "landscape">🥵🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🥵</div> |
There was a problem hiding this comment.
Suggested change
| <div class = "landscape">🥵🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🥵</div> | |
| <div class="landscape" >🥵🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🥵</div> |
tgoslee
reviewed
Dec 22, 2021
|
|
||
| const changeGarden = ()=> { | ||
|
|
||
| const landContainer = document.querySelector("#landscape") |
There was a problem hiding this comment.
your landscape is a class name in HTML not an id. So you could do document.getElementsByClassName("landscape")
tgoslee
reviewed
Dec 22, 2021
| cityNameInputEl.addEventListener("input", changeCityName) | ||
|
|
||
| const resetButton = document.getElementById("cityNameInput") | ||
| resetButton.addEventListener("click", changeCityName) |
There was a problem hiding this comment.
instead of calling the changeCityName function, you should create a function to reset the city name back to the default city name
tgoslee
reviewed
Dec 22, 2021
| width: 480px; | ||
| height: 30px; | ||
| align-self: flex-end; | ||
| /* display: block; */ |
tgoslee
reviewed
Dec 22, 2021
| align-self:center; | ||
| margin-left: 30%; | ||
| font-size: larger; | ||
| /* background-image: linear-gradient(315deg, #000000 0%, #ffffff 74%); */ |
|
This is a good start. I like the background and gifs you chose to use. I added some comments on refactoring your code and adding functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.