Wilson-Munson-Amethyst-Weather-Report-C19

[lindsaybolz]

No description provided.

[mikellewade]

Love how you all chose to use this psuedostate! I think that it is great practice for what you will see in React though it will be utilized differently!

[mikellewade]

Pieces of code like this are usually found in an event handler that runs on the event DOMContentLoaded, basically once the page is html is loaded on the webpage you will run a bunch of initial logic such as grabbing elements and adding event handlers to them. It will look something like this:

document.addEventListener("DOMContentLoaded", function () {
    state.increaseTemp = document.querySelector("#increase-temp");
    state.decreaseTemp = document.querySelector("#decrease-temp");
    state.displayTemp = document.querySelector("#display-temp");
    state.resetButton = document.querySelector("#reset-button"); 
    state.searchButton = document.querySelector("#search-button");
 
    
    state.increaseTemp.addEventListener("click", increaseTemperature);
    state.decreaseTemp.addEventListener("click", decreaseTemperature);
    ...
}

This is also usually found at the bottom of the file too, that way you can put all your function definitions for event handlers above it! This also just adds an extra layer of protection when it comes to things loading in order.

[mikellewade]

Usually you want to use the preventDefault method to prevent the default behavior of an event, however I don't see the reasoning for doing it here. Is there a reason as to why you want to prevent it from happening?

[mikellewade]

Here's an alternative to promise chaining! You can use the async/await keywords to have your function wait until a promise is fulfilled and then you pass the results of that promise to other pieces of your function like assigning your return values as variables or other things like that. It looks something like this:

const findCityLocation = async () => {
    let lat;
    let lon;
    const resp = await axios.get('http://127.0.0.1:5000/location', {
        params: {
            q: document.getElementById("city").value
        }
    })
    
    try {
      [lat, lon] = resp.data[0]
      getWeather({ lat: lat, lon: lon});
    } catch (error) {
       console.log(error)
    }
};

[mikellewade]

Awesome job everyone! You really ate this one up! Please feel free to reach out to me if you have any questions about the comments I left or if you want to discuss anything in greater detail! ⭐️