FarMar - #38
Open
JBoshart wants to merge 15 commits into
Open
Conversation
…turn instances of class? Does it return all instances of class? Now moving on to incorperate the csv file.
…ort the csv file. Altered the test to pass with 500 instances, as that is how many rows are within the csv.
…I want the self.find(id) to return the found account as an array, but it was the way to confirm that one instance of Market was being returned (using .length in the test).
…armar_vendor self methods written, tested, and passing.
… in fact returning a collection of venndors. Also added must_be_instance_of assertions, so that is cool.
…getting tests for products method to pass.
…on a lightbulb and made me go back and basically re-write everything. Which is good! The required methods and tests are in place for every class, except sale. For sale I still need to do the between time and time method, but...it looks complicated and I want to start fresh tomorrow on that. Anyway. I wrote a novel. Comments are probably not supposed to be like this, but...yeah. Here it is.
…s returning the correct results.
…he practice stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boop. Pull request. ...this is Jillian.