Shipping Service Val and Sarah - #9
Open
pottery123 wants to merge 40 commits into
Open
Conversation
…hey kinda disappeared
…ad given that code to someone on Slack so I was able to paste it back in, whoops. This commit contains that USPS test code.
…on oops, fixed that
…r some reason. oh well we will figure it out later
|
|
||
| def index | ||
| # adds the request to the log?? | ||
| # HTTParty.post(log_path, body: params.to_json) |
There was a problem hiding this comment.
Generally, it's good coding etiquette to remove any unnecessary comments before making a final PR. It's definitely fair to keep comments that help explain what is happening, like if you feel your audience needs an explanation of what a function does.
|
I remember this project being especially challenging. High five! Good job! 👍 Too bad you weren't able to make a PR with the changes you made to betsy. I might have more feedback then :) Nice commit messages, too! I can generally work out what you did at each commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What we are proud of:
Val: Realizing that we had put the whole shipping-quote architecture on the wrong page and then coming up with a clever workaround to prevent us from having to redo a ton of work
Sarah: ?
petty website
http://agile-shore-50946.herokuapp.com
API Shipping
https://evening-depths-89076.herokuapp.com/
link to petsy repo https://github.com/vconklin/petsy
for some reason we couldn't make a pull request because of the unique way we had to set up our project