Wave 1 - #16
Open
jm-rives wants to merge 8 commits into
Open
Conversation
CheezItMan
reviewed
Nov 21, 2016
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
@jm-rives A good start on it. Wave 1 looks good, although I think the individual .score method should consider the 7-letter word bonus as well.
| K: 5, | ||
| J: 8, X: 8, | ||
| Q: 10, Z: 10 // NO SEMICOLON! | ||
| }; |
There was a problem hiding this comment.
Very nice use of a JavaScript object as a hash!
| highestScoringWord = word; | ||
| // if there is a word that uses all seven tiles award that word an additional 50 pts | ||
| highScore = currentWordScore + 50; | ||
| // if there is a tie, prefer the highest scorring word made with the fewest tiles |
There was a problem hiding this comment.
Shouldn't the score function already count in the 50 point 7-letter-word bonus?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@CheezItMan