Sarah - #22
Open
nahmisa wants to merge 23 commits into
Open
Conversation
| score += this.letterScore[this.word[i]]; | ||
| } | ||
|
|
||
| if (this.word.length >= this.maxLength) { |
There was a problem hiding this comment.
I might argue that the greater than case would be an error rather than the bonus
| } else if (score == highScore) { | ||
| // if the top score is tied between multiple words, | ||
| // pick the one with the fewest letters. | ||
| if (word.length < highScoreWord.length) { |
There was a problem hiding this comment.
It would make more sense to add this to the else if above with an && rather than having another if inside
| }; | ||
|
|
||
| Player.prototype.hasWon = function() { | ||
| return this.totalScore() > 100; |
There was a problem hiding this comment.
Nice use of the inline conditional
|
|
||
| Player.prototype.removeTiles = function(word) { | ||
| this.word = word; | ||
| for(var i=0; i<this.word.length; i++) { |
There was a problem hiding this comment.
Watch your spacing here, it is more pleasing to add spaces between the = and the < for the for loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like Javascript!