WIP, scrabble.js has all of the methods. See comments below. [Brrrrrrackets] - #27
Open
NatashaRaime wants to merge 1 commit into
Open
WIP, scrabble.js has all of the methods. See comments below. [Brrrrrrackets]#27NatashaRaime wants to merge 1 commit into
NatashaRaime wants to merge 1 commit into
Conversation
|
|
||
| //this function shall draw tiles from the TileBag after each play | ||
| Scrabble.prototype.drawTiles = function(num){ | ||
| this.tilesDrawn = tilesDrawn; |
There was a problem hiding this comment.
Where is this tilesDrawn variable coming from?
| /////////////////////////////Scoring Functions//////////////////////////////////////////// | ||
|
|
||
| // this function shall allocate a 50pt bonus for words of 7 characters | ||
| Scrabble.prototype.bonus = function(word){ |
There was a problem hiding this comment.
How is this used? It doesn't seem like the score function is calling it
| for (let current of this.arrayOfWords){ | ||
| //if the score is already a key in scores, shovel the word into the array of its values | ||
| if ((score(current) in this.scores)){ | ||
| this.scores[score(current)].push(current);} |
There was a problem hiding this comment.
When will a word have more than one score?
| if ((score(current) in this.scores)){ | ||
| this.scores[score(current)].push(current);} | ||
| else { | ||
| this.scores[score(word)] = [word];} |
There was a problem hiding this comment.
By calling the score() method here a few times, you're doing a bit of unnecessary work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
highest score function is not fully completed, all other methods work or should work