Nina Mutty - Scrabble - #30
Open
ninamutty wants to merge 4 commits into
Open
Conversation
CheezItMan
reviewed
Nov 21, 2016
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Nina,
I put a few comments in here, but very well done.
| // Put all of this in prototype | ||
| Player.prototype = { | ||
| play: function(add) { | ||
| return this.plays.push(add); |
There was a problem hiding this comment.
What about if the player has already won?
Check requirements.
| totalScore: function() { | ||
| total = 0; | ||
| scrabble = new Scrabble(); | ||
| for(var i=0; i < this.plays.length; i++) { |
There was a problem hiding this comment.
Shouldn't there be some vars in these variable declarations?
| highestWordScore: function() { | ||
| scrabble = new Scrabble(); | ||
| return scrabble.score(scrabble.highestScoreFrom(this.plays)); | ||
| } |
| totalScore += 8; | ||
| } else if (this.POINT_LIST[6].includes(word[i])) { | ||
| totalScore += 10; | ||
| }; |
There was a problem hiding this comment.
Interesting, so this just skips anything that's not a letter.
| console.log(s.highestScoreFrom(["aaaaad", "aaaaaaa"])); // 'aaaaaaa' | ||
| console.log(s.score("")); | ||
| console.log("Cat: " + s.score("cat")); | ||
| console.log(s.highestScoreFrom(["", ""])); |
| for (var i=0; i < num; i++) { | ||
| randomNumber = Math.floor(Math.random() * this.tiles.length); | ||
| pulledTiles.push(this.tiles.splice(randomNumber, 1)[0]); | ||
| } |
There was a problem hiding this comment.
Good use of push and slice to take letters out of the tilebag and put them into pulledTiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline complete and tilebag drawTiles method complete