Jeannie's Scrabble - #38
Open
BJHunnicutt wants to merge 8 commits into
Open
Conversation
CheezItMan
reviewed
Nov 21, 2016
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Jeannie, wow, this is an amazing piece of work. Just a few comments, but this is an amazing amount of work.
| [".", "=", ".", ".", ".", "*", ".", ".", ".", "*", ".", ".", ".", "=", "."], | ||
| ["\#", ".", ".", "+", ".", ".", ".", "\#", ".", ".", ".", "+", ".", ".", "\#"] | ||
| ]; | ||
| }; |
|
|
||
| // 7-letter word bonus | ||
| if (len == 8) {score = score + 50;} | ||
| return score; |
There was a problem hiding this comment.
Where did len come from? It looks like a global variable initialized in the for loop. Better that's not used.
Also why are you comparing it with 8?
CheezItMan
reviewed
Nov 21, 2016
| } | ||
| // the shortest of two words with the same score | ||
| else if (this.score(word) == this.score(highest) && word.length < highest.length) { | ||
| highest = word; |
There was a problem hiding this comment.
What about if the words are tied, but one is 7-letters long?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, forgot to pull this earlier.