Kelly Tran: Scrabble JS - #41
Open
KellyPT wants to merge 2 commits into
Open
Conversation
| highestScore = wordScore; | ||
| } | ||
| else if (highestScore === wordScore && highestWord.length !== 7 && highestWord.length > wordLen ) { | ||
| highestWord = arrayOfWords[i]; |
There was a problem hiding this comment.
You're using the arrayOfWords[i] variable a bunch so it might be good to assign it to a variable to make the code more readable.
| }; | ||
|
|
||
| this.highestScoreFrom = function(arrayOfWords) { | ||
| var highestWord = arrayOfWords[0]; |
There was a problem hiding this comment.
Nice job using the score of the first word to ensure accurate results
|
|
||
| // hasWon(): Function which returns true if the player has over 100 points, otherwise returns false | ||
| Player.prototype.hasWon = function() { | ||
| if (this.totalScore() > 100) { |
There was a problem hiding this comment.
Good! Note: you can use ternary operators (using the ?) in JS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did it! Yay! Thank you for the deadline extension and arranging a tutor for me! @kariabancroft @droberts-ada