Skip to content

shaunna wiens --carets#24

Open
skwiens wants to merge 45 commits intoAda-C8:masterfrom
skwiens:master
Open

shaunna wiens --carets#24
skwiens wants to merge 45 commits intoAda-C8:masterfrom
skwiens:master

Conversation

@skwiens
Copy link

@skwiens skwiens commented Dec 4, 2017

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? The model plays the same role as the model in Rails. It sets up a type of object that has attributes and can have functions for business logic. It also has built in functions for validations
How did the presence of Models and Collections change the way you thought about your app? It made it easier to think in terms of Object Oriented design. It also made it easier to think of the app in the same way that I would a Rails app
How do Backbone Events compare to DOM events? Backbone events are triggered by change in the data of the models or collections. DOM events are triggered from user input of some sort. Usually a Backbone even will be triggered by a DOM event, but that doesn't mean that a DOM event usually triggers a Backbone event.
How did you approach filtering? What was your data flow for this feature? I began using filtering similar to how we were shown in class, but after looking at the documentation I realized that for filter I just needed to return true. This caused me to change my filter so that it could match things that weren't case sensitive.
What do you think of Backbone in comparison to raw JavaScript & jQuery? I don't know if I want to compare them since Backbone is built on JS and JQuery, and therefore uses them as well. I like that it helps me organize my code a little more and I can think similar to how I did with Rails, but I dislike that I still feel lost in using it and know how much potential it has.
Do you have any recommendations on how we could improve this project for the next cohort? I think there are a lot of great ideas in here, but trying to implement them all in a new environment is a bit tricky. I feel like I got caught up for too long trying to do a few things such as display my error messages correctly, get a working modal, or create a responsive website based on the presented wireframe and surprising input. Maybe scale back on the cool new display features while also implementing a new environment.... or make them obviously optional.

Extra: I know that I have several bugs in my code, but I also feel that I just need to get the assignment turned in, so I'm sorry! Some things that I want to try to fix later (if there's time) include fixing the status modal as it only shows once, creating a dropdown category for selecting a continent, create dynamic inline error messages, fix the responsiveness of my website, allow the website to sort filtered trips as well as the entire trip list, have a button to get all trips, clean up some code that may not be being used, and some more. I know that I could do these thing, but this time I ran out of time... I'm sorry!

@CheezItMan
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well done
Comprehension questions Check
Organization
Models and collections are defined in separate files Check
Code that relies on the DOM is located in or called by $(document).ready Check
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM) Check
Functionality
Display list of trips Check
Display trip details Check
Register for a trip Yes, but no feedback to the user letting them know the registration worked!
Add a trip Not working because the select isn't working with the JavaScript, see my in-code notes.
Sort trips Check
General
Snappy visual feedback for user actions I like the modals and the use of the jQuery library you included.
API error handling You've got the code in place to do so but it's hard to test since the select isn't working.
Client-side validation Nice work on a modal to display errors, I would suggest putting the errors in place on the add-trip modal, so it doesn't cover up the input.
Overall A good attempt, some things not working, but shouldn't be hard to fix. The modals are neat, but the error messages cover up the inputs. See my in-code notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants