Open
Conversation
…e messages or changes pages
…rip page if successful, show errors and do not clear form if unsuccessful
…olumn and direction of sort
BackTREKWhat We're Looking For
|
CheezItMan
reviewed
Dec 5, 2017
| const loadFormFields = function loadFormFields(formId, formFieldsArray) { | ||
| clearContent(); | ||
| formFieldsArray.forEach((item) => { | ||
| $(`#${formId}`).append(formTemplate({field: item})); |
There was a problem hiding this comment.
This is a very clever method to generate the form you need. The downside is that you can't create controls like select which keep a user from entering an invalid choice. Similarly you can't have inputs of type number.
How could you adapt this method to improve the UX?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BackTREK
Congratulations! You're submitting your assignment!
Comprehension Questions