Kimberley Zell - Pipes - BackTrek#36
Open
kimpossible1 wants to merge 13 commits intoAda-C8:masterfrom
Open
Conversation
…servation form when reserve a spot is clicked
BackTREKWhat We're Looking For
|
CheezItMan
reviewed
Dec 10, 2017
|
|
||
| DISPLAY_TRIP_FIELDS.forEach((field) => { | ||
| const headerElement = $(`th.sort.${ field }`); | ||
| headerElement.on('click', (event) => { |
There was a problem hiding this comment.
You also need to add something to style the selected column. Right now it sorts, but doesn't indicate which column was sorted. Adding a class which changes the styling of the th element would work well.
| console.log(reservation.url); | ||
|
|
||
| // reservation.save({}, { | ||
| if (reservation.save) { |
There was a problem hiding this comment.
This doesn't actually call the reservation's save function. Instead it checks to see if it exists.
Remember this isn't Rails!
Instead you need:
reservation.save({} {
success: someEventHandler,
error: someOtherEventHandler
});
| // console.log(`In initialize: for the book ${ this.get('title') }`); | ||
| }, | ||
|
|
||
| validate(attributes) { |
There was a problem hiding this comment.
This is good, but you also need to test for:
- Continents that are valid (Asia, Africa etc).
- Valid numeric values for weeks and cost
| const Reservation = Backbone.Model.extend({ | ||
| url: function () { | ||
| return `https://ada-backtrek-api.herokuapp.com/trips/${this.get("trip_id")}/reservations`; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BackTREK
Congratulations! You're submitting your assignment!
Comprehension Questions