Pipes - Kee - BackTREK

[anemonekey]

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What role does the Model play in Backbone?	Models are handy places to store logic and data structure, like they do in Rails.
How did the presence of Models and Collections change the way you thought about your app?	It helped set a foundation for how I wanted my data to look and interact with one another.
How do Backbone Events compare to DOM events?	Backbone events are triggered by changes in data while DOM events depend on user actions.
How did you approach filtering? What was your data flow for this feature?	Did not do this..
What do you think of Backbone in comparison to raw JavaScript & jQuery?	Backbone helped DRY out code and made things more readable.
Do you have any recommendations on how we could improve this project for the next cohort?	I think a lighter project before Interview Week would have been better. This had a lot of information that I didn't absorb because I was dazed with the foreboding of interviews;;

[CheezItMan]

BackTREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	You need more commits and keep the commit messages describing the functionality provided.
Comprehension questions	Check, although Backbone model also handle API communication
Organization
Models and collections are defined in separate files	Check
Code that relies on the DOM is located in or called by $(document).ready
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)
Functionality
Display list of trips	Check
Display trip details	Check
Register for a trip	MISSING
Add a trip	INCOMPLETE you don't have the function you reference to read the details from the form.
Sort trips	You sort the list, but you don't render the results. See my notes in your code.
General
Snappy visual feedback for user actions	The styling here is really great. I really like it. It looks really nice and you obviously put a lot of time into it.
API error handling	MISSING
Client-side validation	MISSING
Overall	You have wave 1 complete, and Wave 2 partially complete, but you have a lot of work to do. You definitely spent a lot of time on styling, but should have put more into the functionality. I know it was a crazy week, but you definitely need practice using Backbone Models and collections. Try putting more time into this area on our Stock app this week.

[CheezItMan]

You don't seem to have any JavaScript catching this form's submit action, so it causes a page reload.

[CheezItMan]

You also need an:

tripList.on('sort', render);

Otherwise it sorts, but doesn't display the results on the screen!

[CheezItMan]

You don't HAVE a readForm() function.