Conversation
BackTREKWhat We're Looking For
|
|
|
||
| // import Backbone from 'backbone'; | ||
| // | ||
| // const Reservation = Backbone.Model.extend({ |
There was a problem hiding this comment.
Looks like you were on a good track!
| $('th.sort').removeClass('current-sort-field'); | ||
| $(`th.sort.${ tripList.comparator }` ).addClass('current-sort-field'); | ||
|
|
||
| tripList.on('update', renderAll); |
There was a problem hiding this comment.
These should be in $(document(.ready this will eventually cause lots of rendering when a new model is added or if it's been sorted multiple times.
Only add the listener once, not every time it renders.
| const bookTripID = $(event.target).attr('data-id'); | ||
| let reservationFormData = | ||
| $('#reservation-form').serialize(); | ||
| makeReservation(reservationFormData); |
There was a problem hiding this comment.
Here you're calling makeReservation with the wrong paramater. The 1st parameter should be the tripID
| } | ||
|
|
||
| if (!CONTINENTS.includes(attributes.continent)) { | ||
| errors.continent = [' is not a valid continent.']; |
There was a problem hiding this comment.
This would overwrite the blank continent message. Instead you'll need to do:
if (errors.continent) {
errors.continent.push('is not a valid continent');
} else {
errors.continent = [' is not a valid continent.'];
}
|
|
||
| $('#individual-trip').hide(); | ||
| const newTrip = new Trip(readAddTripForm); | ||
| tripList.add(newTrip); |
There was a problem hiding this comment.
no checking for validations?
Also the trip doesn't have an ID yet (gets the from the API), so you should wait until the save is successful and then execute tripList.fetch() to pull down the updated Trip from the API (with an ID).
| validate: function(attributes) { | ||
| const errors = {}; | ||
| const CONTINENTS = ['Asia', 'Africa', 'Australasia', 'Europe', 'South America', 'North America', 'asia', 'africa', 'australasia', 'europe', 'south america', 'north america'] | ||
| if (!attributes.name) { |
There was a problem hiding this comment.
you'll need this in front of attributes
like:
if (! this.attributes.name) {
2 participants
BackTREK
Congratulations! You're submitting your assignment!
Comprehension Questions