Carets - Guillermina by murog · Pull Request #23 · Ada-C8/MediaRanker

murog · 2017-10-16T11:27:03Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a method for the Work model that was able to determine a spotlight work. It did so by checking the length of the votes array for works across each type of category.
Describe how you approached testing that model method. What edge cases did you come up with?	I made sure that the spotlight method raised errors if attempted to be used with hashes that did not contain works. I originally had the method set up so that it would return a spotlight without an argument, but I changed it so that it could be more easily tested.
Describe an edge case test you wrote for a controller	It should render a 404 page if a user attempts to delete a work that does not exist.
What are `session` and `flash`? What is the difference between them?	They are both temporary hash-like objects. Flash stores information that you could present to the user to inform them of successes and errors. Flash notices only exist through the following request. Sessions are stored in a browser's cookies and exist for as long as the browser window is open.
Describe a controller filter you wrote.	In the application controller, before any action is acted upon, the application searches to see if a user is logged in. If they are logged in, that user is assigned to an instance variable.
What was one thing that you gained more clarity on through this assignment?	Controller testing! Building the application became much more manageable once returning to the pseudocode-red-green-refactor cycle.
What is the Heroku URL of your deployed application	https://gm-media-ranker.herokuapp.com/ (However, I am getting a 503 status code at the moment...)
Do you have any recommendations on how we could improve this project for the next cohort?	I believe this one would have been more appropriate as a pair project, as opposed to ride-share.

CheezItMan · 2017-10-18T21:29:07Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good number of commit and commit messages
Comprehension questions	Check, I agree the compressed week made this individual project more difficult.
General
Rails fundamentals (RESTful routing, use of named paths)	Good RESTful routes
Semantic HTML	Good Semantic HTML
Errors are reported to the user	Check, although now I see that you're using OAuth, I can't check trying to delete a work without logging in, or upvoting
Business logic lives in the models	You've got some, but I think you should have sorting works in categories by their number of votes in the Model.
Models are thoroughly tested, including relations, validations and any custom logic	You've got tests, but some are failing (2). I also left some notes in your code.
Controllers are thoroughly tested	You need to include status codes in some of your controller tests. Also some more edge-case testing, but overall pretty good. I left some notes in your code. However I had 17 tests failing and 15 errors... Lots of things like unknown paths, and incorrect status codes etc. That seems to be because you're adding OAuth to your project locally. Probably should get your tests to pass in a branch before merging it into master.
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check
The ID of the current user is stored in the session	Check
Individual user pages and the user list are present	Check
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Media pages contain lists of voting users	Check
Wave 3 - Styling
Foundation is used appropriately	Nicely done
Look and feel is similar to the original	Check
Overall	Well done. It seems you've added OAuth to your repo which made evaluating your tests difficult. I left some notes in your code. You hit most of the requirements with minor criticisms.

CheezItMan · 2017-10-18T19:43:15Z

test/models/work_test.rb

+    output.must_be_instance_of Hash
+  end
+
+  it "should return values that are arrays" do


I would also test that they are in the proper order...

CheezItMan · 2017-10-18T19:43:34Z

app/models/work.rb

+  validates :title, presence: true
+  validates :title, uniqueness: true
+
+  def self.all_works_by_title


Shouldn't this be by the # of votes?

CheezItMan · 2017-10-18T19:46:17Z

test/models/vote_test.rb

+  let(:work) { Work.new }
+  let(:vote_1) { votes(:vote_1)}
+
+  it "must have a valid work and user to be valid" do


I would also add a test to verify that two votes can't have the same work_id and user_id.

So a user can't vote for the same work twice.

CheezItMan · 2017-10-18T20:27:39Z

test/controllers/main_page_controller_test.rb

+describe MainPageController do
+  it "should get index" do
+    get main_page_index_url
+    value(response).must_be :success?


you could instead do:

must_respond_with :success

CheezItMan · 2017-10-18T20:29:15Z

test/controllers/sessions_controller_test.rb

+    post login_path, params: {username: "alyssa"}
+  }.must_change 'User.count', 1
+  must_respond_with :redirect
+  must_redirect_to root_path


I would also test:

id = find_by(username: 'alyssa').id id.must_equal session[:user_id]

CheezItMan · 2017-10-18T21:01:49Z

test/controllers/sessions_controller_test.rb

+  proc {
+    post login_path, params: {username: nil}
+  }.must_change 'User.count', 0
+  flash[:error].must_equal "User not logged in successfully"


Please use status codes.

CheezItMan · 2017-10-18T21:03:15Z

test/controllers/sessions_controller_test.rb

+
+describe SessionsController do
+
+it "going to the login_form page is successful" do


Fix AUTOINDENT!

CheezItMan · 2017-10-18T21:05:26Z

test/controllers/works_controller_test.rb

+    }.must_change 'Vote.count', 0
+    must_respond_with :redirect
+    must_redirect_to work_path(works(:anti).id)
+    flash[:error].must_equal "You've already upvoted this!"


I would also have a test voting for a work that doesn't exist, or voting if not logged in.

murog added 30 commits October 10, 2017 13:51

created rails app

9873973

created models, model relationships and controllers

e0936e4

wrote seed file and seeded database

6f85116

created main page controller with index view

f34225e

updated routes to include resources and defined rooth path

8bdb090

updated layout to include header and nav

0ef381e

updated main page index to include spotlight and top lists

faa1a33

loops through all works and displays them on main page

b590c59

spotlight and all_works_by_title method

beeb6f0

updated work model tests

ba462b0

added user and work fixtures

70f030b

update private main page controller methods to DRY up index

5871a08

update works controller to include private mthods, index includes table

1176795

updated work controller tests

e2b8c8a

passing create tests

4f53e83

failing edit work test

974dc4b

passing edit work test

694f02d

failing show page test

8c72787

passing show work test

6ed3cd5

failing book not found show test

675a5c4

failing delete work test

8a69e6c

failing 404 delete nonexistant work test

3061679

passing destroy tests

05f161d

updated show work html

b56cd86

updated layout to include flash messages

8b678db

updated form

72e8ca6

render form on edit page

d615936

failing work validation tests

368b105

passing work validation tests

9a416e0

failing user validation tests

ec56f5c

murog added 26 commits October 16, 2017 03:36

removed link from css

792f1e7

removed favicon

9f76b9b

put favicon back

683380f

updated work tests

782b3bb

fixed link color

f5966dc

updated routes to fix heroku error

5f8c83b

removed require pry

bc9faad

fixed status section on layout

544cee7

removed default line from works show

4d3f34e

updated styling

f726bcc

updated gemfile with oauth

aa2c8cd

added env

c53d161

added omniauth.rb

809ec36

added create action to sessions controller

9871161

update user model migration

09d50c0

updated login button to create user based on oauth

3169567

added logged_in before filter, skips it main_page

ed62ab2

added skip before action to sessions create

2d66396

added user id to books, users have many works, works belong to user

07d9eba

added require owner method

f2fec69

can only edit, update and delete works that user owns

2646061

works are created with logged in user as owner

e80c1f8

added work's user to show page

1bb1978

moved dotenv into production

0f5f974

oauth uid convert to integer

9ad5ddf

updated assign user method in works controller

fb936af

CheezItMan reviewed Oct 18, 2017

View reviewed changes

murog added 2 commits October 31, 2017 09:58

updated sessions, routes and tests to handle oauth

2771c8e

updated tests to take oauth into consideration, 2 errors currently

bc9c6ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Carets - Guillermina#23

Carets - Guillermina#23
murog wants to merge 93 commits intoAda-C8:masterfrom
murog:master

murog commented Oct 16, 2017

Uh oh!

CheezItMan commented Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

CheezItMan Oct 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		describe SessionsController do

		it "going to the login_form page is successful" do

Conversation

murog commented Oct 16, 2017

Media Ranker

Comprehension Questions

Uh oh!

CheezItMan commented Oct 18, 2017

Media Ranker

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants