Nkiru - Pipes- MediaRanker by nkiruka · Pull Request #30 · Ada-C8/MediaRanker

nkiruka · 2017-10-16T15:52:38Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	A wrote a self method to find the top media, so the method can be called without needing an instance of work. The method checks all the works and finds the media with the highest volts by using the enumerable method max_by
Describe how you approached testing that model method. What edge cases did you come up with?	Did not complete this task: Wanted to test what would happen if there was a tie for the highest votes; my thought was to select the first work. I also would have tested if there were no votes cast by a user. I would have like to test what would have happened if a creator deleted the work with the highest votes, if it will return true that that work no longer has the max votes. Soft passing case: Test that to make sure the method accurately finds the max of work with the highest votes.
Describe an edge case test you wrote for a controller	A bad request is returned if an update is unsuccessful if a work id is invalid. Test is effective because is checks that the work count before an update is requested is the same as the work count after the unsuccessful update.
What are `session` and `flash`? What is the difference between them?	Flash is a special hash that is used to send one time message to controllers and views. Common usage of flash is to denote success or failure of events. session lasts until the user's session is over (i.e when user has closed the browser). Session is similar to hash except that data stored there will not go away after the next request-response cycle.
Describe a controller filter you wrote.	Did not get to use one, focused on functionality of the program.
What was one thing that you gained more clarity on through this assignment?	Model relationships, but still looking forward to more practice
What is the Heroku URL of your deployed application	https://mediajunkiebuff.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?	More project time in class especially if project is assigned over 4 day week.

…ntroller

droberts-sea · 2017-10-20T00:08:07Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Rails fundamentals (RESTful routing, use of named paths)	yes - some extra routes
Semantic HTML	mostly - see inline comments
Errors are reported to the user	mostly - the only place I noticed this missing is when upvoting a work fails
Business logic lives in the models	yes - great work!
Models are thoroughly tested, including relations, validations and any custom logic	some - Missing tests for custom logic. Interesting cases for the `top_ten_x` methods include: what if there are no models with that category? What if there are more than 10?
Controllers are thoroughly tested	mostly - a couple missing, but in general this looks good
Wave 1 - Media
Splash page shows the three media categories	yes
Basic CRUD operations on media are present and functional	yes
Wave 2 - Users and Votes
Users can log in and log out	yes
The ID of the current user is stored in the session	yes
Individual user pages and the user list are present	yes
A user cannot vote for the same media more than once	yes
All media lists are ordered by vote count	yes
Splash page contains a media spotlight	yes
Media pages contain lists of voting users	no
Wave 3 - Styling
Foundation is used appropriately	some - seems like there is a lot to explore here still
Look and feel is similar to the original	some
Overall	Great job overall! I've left a few inline comments to review, and I want to make sure you take some time to experiment with Foundation on bEtsy, but in general I am quite happy with this submission. Keep up the hard work!

droberts-sea · 2017-10-19T23:48:04Z

config/routes.rb

+
+  resources :votes
+
+  resources :users


I'm not sure you need all seven RESTful routes for votes and users. Be careful when using resources to only generate the routes you plan to use.

droberts-sea · 2017-10-19T23:49:02Z

app/views/works/index.html.erb

+
+<table>
+  <h3> Albums </h3>
+  <thead>


Is there a way you could use a view partial to DRY up repeated HTML on this page?

Also, I would like to see each category in its own <section> here.

droberts-sea · 2017-10-19T23:51:12Z

app/controllers/works_controller.rb

+  def show
+    find_work_by_params_id
+    # @work = Work.find_by(id: params[:id])
+    # unless @work


You are basically using find_work_by_params_id as a controller filter already here - the last step is to take advantage of Rails's syntactic sugar to clean up the code a bit.

droberts-sea · 2017-10-19T23:52:03Z

app/models/work.rb

+  def self.top_ten_albums
+  album = Work.where(category: "album")
+  return album.sort_by { |work| -work.votes.count }.take(10)
+  end


Watch your indentation here

droberts-sea · 2017-10-19T23:56:25Z

test/controllers/users_controller_test.rb

+describe UsersController do
+  # it "must be a real test" do
+  #   flunk "Need real tests"
+  # end


Even though we didn't ask you to test login/logout, you should at least have tests for index and show here.

droberts-sea · 2017-10-19T23:57:54Z

test/controllers/works_controller_test.rb

+
+  #question should be what will cause the index page not to show. since it is ordered by title then if title isn't present maybe it wont show??  I wonder if I could mess with the form and that could result in html not rendering properly. perhaps!
+
+#not sure what to do with this yet,  need an invalid case.  do I need to check work id


This is a good question! Could be there is no failure case here, which would mean all the tests for this action result in success.

droberts-sea · 2017-10-19T23:59:11Z

test/controllers/works_controller_test.rb

+
+     must_respond_with :not_found
+     Work.count.must_equal start_work_count
+   end


What if you try to destroy a work with votes? Can you do it? What happens to the votes?

These are exactly the sorts of questions that the end-to-end style of a controller test is suitable to answer.

nkiruka added 30 commits October 10, 2017 20:14

Initial Rails setup

ad25bc4

Created users, votes and works controllers

7f93890

Created index view and index method

60c1fbc

Created models

9dcdd92

Added models and migration

ccfcf2e

Updated seed file

7a2df7c

Added restful routes for each controller

95e812d

Added list of works to the index action and view

3e131b4

Link to works show page from index page

595a09a

Added form-for to new view and create action

e17242c

Created edit view and added edit method to works controller

557defd

Added update method to works controller

aae6068

Added delete method

ab6506f

Added testing for user model

3e3bdf2

Add home page, custom route and home index

ab6be21

moved pry to development and test

8aac8b0

Added tests for user model

1435937

added tests for vote model

a71db50

Edited vote model tests

6d04bf8

Added data to user fixture yml

5343062

Added data to user yml

9b34336

Added test to check vote count for user

9726d3e

Tested belongs_to relationship

dbb4e2f

Added tests for validation and relationships for work model

dad562c

Added tests for create action and modified create method for works co…

71b0b63

…ntroller

Added tests for show action and updated show method

b70c65d

Added tests for edit action and modified edit method

a3b157c

Added controller filter for show and edit method

6220951

Added description to form_for

37c2a1d

Test to check if work is destroyed

adabfad

nkiruka added 28 commits October 15, 2017 13:02

Modified tables for user show and index pages

25c3e00

Added custom routes to create a vote

01844f4

Added show method

085a832

Added a create method

7edd24c

created user show view

ebfdb4c

Added upvote button

0d456e9

Add link to view users

70aa479

commented out categories

8e8e9f0

Added button for upvote and link for vote count

e8101d1

Add link for voted on

210d010

Add link for when userjoins

dace45d

Added foundation to stylesheets

f84e4f8

Removed custom routes for work

2cf985a

Styled nav bar

a9bb0c8

Styled header and nav

7c18fc3

Added a table to home index

63aa218

Styled sections

3cf353d

Created method to find top media

31881a1

call method to calculate top media

d2e1f6b

Created method to find top for each work category

79dcabf

Updated view with method calls

abd93dc

Edit code

280cbe1

Adjusted media spotlight method to only return 1 work

50c780e

call work model methods

04fccf0

added horizontal linesfor headings

6e3eb1b

Added vote count to top media

64830ee

Added instance variables for each work category to index

1b5bbed

Call .each method on each work category to show list

a36983d

droberts-sea reviewed Oct 20, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nkiru - Pipes- MediaRanker#30

Nkiru - Pipes- MediaRanker#30
nkiruka wants to merge 74 commits intoAda-C8:masterfrom
nkiruka:master

nkiruka commented Oct 16, 2017 •

edited

Loading

Uh oh!

droberts-sea commented Oct 20, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

droberts-sea Oct 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		#question should be what will cause the index page not to show. since it is ordered by title then if title isn't present maybe it wont show?? I wonder if I could mess with the form and that could result in html not rendering properly. perhaps!

		#not sure what to do with this yet, need an invalid case. do I need to check work id

Conversation

nkiruka commented Oct 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Media Ranker

Comprehension Questions

Uh oh!

droberts-sea commented Oct 20, 2017

Media Ranker

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nkiruka commented Oct 16, 2017 •

edited

Loading