Pipes - Bennett - Solar System

[bennettrahn]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
What was the purpose of the initialize method in your class?	to define all the instance variables and take input for those variables from the creation of a new class.
Describe an instance variable you used and what you used it for.	@distance_from_sun gave the distance from the sun in AU so that you could find the distance between planets by using simple subtraction.
Describe what the difference would be if your SolarSystem used an Array vs a Hash.	My solar system didn't use a hash? In wave one I had one and it was nice to call the keys, but once I switched to methods that was easier. Arrays are hard because you have to know the index of some thing so its not intuitive.
Do you feel like you used consistent indentation throughout your code?	yes? cmd-I works wonders.

[droberts-sea]

Solar System

What We're Looking For

Feature	Feedback
Created Custom Class with initialize method & instance variables.	Yes
Used an Array to store a list of planets in the SolarSystem class.	Yes
Readable code with consistent indentation.	Yes
Created a pull request with your name & the template questions answered.	Yes

Great work overall! I've commented on a bunch of little things below, but in general I'm quite happy with the code you've submitted.

[droberts-sea]

I really like the idea of making this its own method. Very concise bit of functionality.

You're implementation is a little odd to me though - do you really need to pull out the planet names? Why not:

@planets.each do |planet|
  if planet.name == name
    return planet
  end
  return nil
end

[droberts-sea]

This is a clever way to make your functionality more flexible. Here is a question: Why not pass in the whitespace you want as type, instead of a symbol representing it?

[droberts-sea]

I like this table.

[droberts-sea]

You use the term class often in variable names. I would recommend avoiding this - in general, it's usually clear when you've got an instance of a class. Instead, calling these mercury or venus might be more readable.

[droberts-sea]

Since you're creating all these local variables just to add them to an array, a more concise way to do this might be:

planet_array = [
  Planet.new("Mercury", 3.285e+23, 1, 9525, "Orange", 0.24, 0.39),
  Planet.new("Venus", 4.87e+24, 2, 23628, "Yellow", 0.62, 0.72),
  # ...
]
our_solar_system = SolarSystem.new("Milky Way", 1.32e+10, planet_array)

This makes it clear to the reader that we won't be using the planets individually, only through the collection, and also saves you having to come up with a bunch of variable names.