Open
Conversation
Solar SystemWhat We're Looking For
|
tildeee
reviewed
Aug 22, 2017
| @@ -0,0 +1,89 @@ | |||
|
|
|||
| class SolarSystem | |||
| attr_reader :ss_user_choice | |||
There was a problem hiding this comment.
I don't think you need an attr_reader for ss_user_choice-- you've defined ss_user_choice as the name of a method. attr_reader helps make method definitions if you give it an instance variable.
tildeee
reviewed
Aug 22, 2017
| end | ||
|
|
||
| class Planet | ||
| attr_accessor :name, :moons, :year_length, :distance_from_the_sun, :named_after, :print_planet |
There was a problem hiding this comment.
Again, you don't need to add print_planet to an attr_accessor. print_planet is the name of a method, which can already be called with .print_planet. attr_accessors are for instance variables
|
Good job on the assignment. You successfully created instances of SolarSystem and Planet and used them! I've added a couple of notes about your code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod in your class?SolarSystemused anArrayvs aHash.