Conversation
Static SiteWhat We're Looking For
|
|
Your indentation was a little off in a few places, and sometimes you weren't consistent about how you were opening and closing your tags between one line or multiple lines I appreciate that you created some empty tags for the practice of them (I understand your site isn't quite structured to have a "nav" or a "footer") :P But feel free to remove these. I could see a use for the also, good job making it mobile friendly! also... you knew this would happen but... I LOVE YOUR WEBSITE 🎉 😻 I T ' S S O G O O D ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ ✨ |
|
|
||
| </nav> | ||
| </header> | ||
| <section class="header_box"> |
There was a problem hiding this comment.
I actually can't find a use for this section and it's repeated on every page
|
|
||
|
|
||
| <section class="photo_box"> | ||
| <article id="index"> |
There was a problem hiding this comment.
this might actually be a good use case for not using <article> but instead using <div>
| <a href="../assets/overwatch_guess.gif"><img src="../assets/overwatch_guess.gif" alt="overwatch guessing game"/></a> | ||
| <h3>HTML&CSS</h3> | ||
| <a href="../assets/waow_meow.gif"><img src="../assets/waow_meow.gif" alt="meowspace website"></a> | ||
| <a href="../assets/personal_page.gif"><img src="../assets/personal_page.gif"></a> |
There was a problem hiding this comment.
this is the one img tag you forgot some alt text for!
| <img src="../assets/strawberries.png"/> | ||
| <h3></h3> | ||
| <p>well what is happening</p> | ||
| </article> |
|
|
||
| </section> | ||
| <section class="main_box"> | ||
| <h2>hi i'm guillermina muro,</h2> |
There was a problem hiding this comment.
you can probably make this an <h1> instead of an h2 and style it the way you want to. h1 is for the most important information on the page, which this is
2 participants
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions