Open
Conversation
Static SiteWhat We're Looking For
|
tildeee
reviewed
Oct 4, 2017
|
|
||
| <section class="weekly-posts"> | ||
| <article class="main-text"> | ||
| <h2>Week 2</h2> |
There was a problem hiding this comment.
I would probably put each "post" in a different <article> tag
tildeee
reviewed
Oct 4, 2017
| <section class="main-text"> | ||
| <h2>Recent Projects</h2> | ||
| <hr /> | ||
| <p> |
There was a problem hiding this comment.
If there were more content here, I might have put each "project" in a separate container that represented one "project" each
tildeee
reviewed
Oct 4, 2017
| height: 0; | ||
| } | ||
|
|
||
| .clearfix { display: inline-block; } |
There was a problem hiding this comment.
doesn't look like you ended up using .clearfix anywhere?
|
Good work! Overall good, clean work. There are some places in HTML where the meaning of the content could be expressed more in HTML, such as a blog post being its own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static Site
Congratulations! You're submitting your assignment!
Comprehension Questions