Pipes - Angela - Static Site

[awilson2017]

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I used not an HTML Validator
Why is it important to consider and use semantic HTML?	It helps future me and other programmers understand the content of the blocks.
How did you decide to structure your CSS?	I utilized one CSS sheet for all my pages because many of the pages had similar styles. Beyond that I used comments to clarify chunks of code.
What was the most challenging piece of this assignment?	Trail and error was the most challenging portion of the assignment. However, utilizing dev tools like 'inspect' was helpful.
Describe one area that you gained more clarity on when completing this assignment	I learned more about padding and margin and how the two interplay.

[Hamled]

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	No. There's only one commit for this project, and ideally we would split our projects up into many small commits.
Answered comprehension questions	✅
Page fully loads	✅
No broken links (regular or images)	✅
Includes at least 4 pages and styling	Mostly. The "Code-Journal" blog page is empty, but does technically exist.
HTML
Uses the high-level tags for organization: header, footer, main	Mostly. We could surround all of the page contents between header and footer with a main tag to be more complete.
Appropriately using semantic tags: section, article, etc.	✅
All images include alternate text	✅ (There aren't actually any img tags on the site.
CSS
Using class and ID names in style declarations	✅ However, many of these classes are defined by their styling impact (e.g. grey-background) rather than their semantic intent (e.g. second-article).
Style declarations are DRY	✅
Overall	The video background on the homepage is really cool! I noticed that there were a ton of (I think?) unused files in a video/ folder within your project. Please keep an eye on what is being added when you use git add . or git commit -A.

[Hamled]

We should have this footer section on every page, similarly to the header tag. This will help maintain a consistent styling and layout throughout the site.

[Hamled]

We should probably surround these two article tags within a main tag:

<main>
  <article class="text-align-center">
    ...
  </article>
  <article class="grey-background text-align-center">
    ...
  </article>
  <article>
    ...
  </article>
</main>

[Hamled]

We do not need this img tag as it has no reference to a source image.

[Hamled]

We do not need the class attribute on this element as it has not been set to any value.