Kayla Ecker - Carets

[kaylaecker]

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I used brackets to check in real time, and didn't use the HTML Validator, although I will on the next project. Hadn't thought about it until this question.
Why is it important to consider and use semantic HTML?	Creates clearer/easier to read code and it looks more elegant. Brings concepts together more clearly.
How did you decide to structure your CSS?	My original structure was not very good, so I decided to redo it completely yesterday. I decided to start from a more simple entry page (with a fun feature), and did a bones set up of each page prior to entering more css. I worked with the flow of the page the best I could. To see the commits for my retry, please go to https://github.com/KaylaEcker/static-site-retry
What was the most challenging piece of this assignment?	The design, definitely. Choosing colors/what text to use/trying to figure out how to make it look not so busy and more legible. It could still use more work looking less.. dark/old styled.
Describe one area that you gained more clarity on when completing this assignment	I understand a lot more now! Deciding to redo the project yesterday was a big help, and I understand more of the structuring (although could dry up the code more in the future)

[CheezItMan]

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	Not a lot of commits, the commit messages are ok given the amount of work done in'em. It's better in the retry.
Answered comprehension questions	Bracket are a good idea. Semantic HTML also helps the screen readers make sense of your site. Be careful in future project restarting. After the break, redoing a project from scratch just isn't a good idea.
Page fully loads	Check
No broken links (regular or images)	Check
Includes at least 4 pages and styling	Check
HTML
Uses the high-level tags for organization: header, footer, main	Yes, you do have a bit of extra whitespace in your HTML code. Some is ok, yours is a bit excessive.
Appropriately using semantic tags: section, article, etc.	Good work here.
All images include alternate text	You are missing some alt attributes and some of your image tags are empty. Odd.
CSS
Using class and ID names in style declarations	Check, but the name aren't very descriptive head1 for example. Also make sure all values for your HTML attributes are in quotes ("")
Style declarations are DRY	It look like SOME work was done to DRY your CSS code by grouping some declarations together or use classes to style multiple elements, but a lot of repetition is done here, like with text-align: center and display: inline-block.
Overall	You hit the expectations. I like the way the text-shadow is done, as it makes the text easier to read on the image background. Not bad at all.

[CheezItMan]

The basic framework is done, but it could be filled out with more content. I left a few notes in the code.

[CheezItMan]

You need an alt attribute.

[CheezItMan]

Why an empty <img> tag?

[CheezItMan]

huh?

[CheezItMan]

head1 here should be in quotes. You've done this in other places too.

[CheezItMan]

Umm... there are no project links or images...