Skip to content

Jocelyn & Victoria -- Carets#10

Open
jocegonz wants to merge 10 commits intoAda-C8:masterfrom
jocegonz:master
Open

Jocelyn & Victoria -- Carets#10
jocegonz wants to merge 10 commits intoAda-C8:masterfrom
jocegonz:master

Conversation

@jocegonz
Copy link

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? See Google survey
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? We used a guessing method. It didn't take any arguments, but it outputted text about whether it was within the word or not.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? We used a local variable that holds the number of correct letter. We wanted it to be reset after every time it was called.
What code, if any, did you feel like you were duplicating more than necessary? I feel like we did an okay job minimizing duplication, but it would have been nice to make things more succinct with more time.
Is there a specific piece of code you'd like feedback on? We'd like feedback on the length of our class and how it could be split up.

@CheezItMan
Copy link

Word-Guess Game

What We're Looking For

Feature Feedback
Baseline
Regular Commits with meaningful commit messages. A few more commits would be better. One commit for the Word class however.
Readable code with consistent indentation. Check
Answered comprehension questions Check, I'm glad you seemed to work well together.
Product Functionalities
Created a Class to encapsulate game functionality. Check
Used methods to DRY up your code. Check
Created instance variables & local variables where appropriate. Check
Used Arrays to store lists of letters guessed. Check
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers.
Programmed "defensively" to detect errors in user input.
Summary Nice use of the random-word gem. My suggestion, that fits my thinking it to make the word and guesses it's own object with a display and a guess method. The Game class would be a driver for the game logic, but that's how I would think of it. Other solutions are also valid. Nice work creating private helper methods for simplifying methods like guessing. It might do with a bit further breaking up. Very nicely done, well organized and you hit all the requirements. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants