Skip to content

Word-Guess_Marisa Morris & Sara Chandler (carets)#15

Open
marisamorris wants to merge 14 commits intoAda-C8:masterfrom
marisamorris:master
Open

Word-Guess_Marisa Morris & Sara Chandler (carets)#15
marisamorris wants to merge 14 commits intoAda-C8:masterfrom
marisamorris:master

Conversation

@marisamorris
Copy link

Word Guess

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How do you feel you and your partner did in sharing responsibilities? Awesome
Describe an instance where you used a method for something to encapsulate the functionality within your class. What does it do? What are its inputs and outputs? The method startGame is called outside of the class and outputs promptuser. The input is taken in through promptuser.
Describe an instance where you used a local variable instead of an instance variable. Why did you make that choice? Gamewords is a local variable set to an array. It was created outside of the class and didn't need to be an instance variable.
What code, if any, did you feel like you were duplicating more than necessary? We tried not to duplicate as much as possible.
Is there a specific piece of code you'd like feedback on? Is there another option for checking user input aside from regex?

@CheezItMan
Copy link

Word-Guess Game

What We're Looking For

Feature Feedback
Baseline
Regular Commits with meaningful commit messages. Good commit messages, but more granular commits would be nicer.
Readable code with consistent indentation. Check, lots of comments as well. Your class was misaligned with the end.
Answered comprehension questions Nice that you used Regex, but you can also split the String into an array and loop through it looking for letters that match, or use some String methods to find the index of matching letters.
Product Functionalities
Created a Class to encapsulate game functionality. Check, but your prompt method was waaaaay too long. There's just too much going on there. You needed to break up the logic into smaller methods.
Used methods to DRY up your code. Methods created, but see above about breaking things up a bit (lot) more.
Created instance variables & local variables where appropriate. Good choices for instance variables.
Used Arrays to store lists of letters guessed. Check
Used variables & random numbers to allow the game to function with multiple words, no hard-coded answers. Check
Programmed "defensively" to detect errors in user input. Check, nice use of Regex to verify that they entered a letter and find
Summary I liked the hangman ASCII art. Nicely done. You hit all the requirements, but you've got a monster method that needs to be broken up. This is something I'd like you to work on in future projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants