Pipes - Lindsey - Ada Trader

[VirtualLindsey]

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How do Backbone Views help structure your code?	It provided a consistent place to interact with specific DOM elements
Did you use jQuery directly in your Views? How, and why?	I used jQuery to read fields, and select elements
What was an example of an event you triggered? Why did you need to trigger it?	I triggered an event after a stock order was completed. I needed to have the quote and order views communicate as to prevent conflicting events.
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different?	Model validations are basically the same. How you test events are very different. It reminds me of the VCR unit testing.

[droberts-sea]

Ada Trader

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	I only see one commit - looks as though your git setup is still giving you trouble. If this persists, you might sit down with an instructor for a more thorough investigation. We wouldn't want you to accidentally loose a bunch of work on your capstone.
Comprehension questions	yes
Organization
Models and collections are defined in separate files	yes
Code that relies on the DOM is located in or called by $(document).ready	yes
Functionality
Quote prices change when clicking Buy and Sell	yes
The Trade History updates when buying and selling a quote	yes
A user can create an open order using the Order Entry Form	yes
An open order removes itself from the open orders and updates the Trade History when fulfilled	yes
General
Has separate views for different parts of the app	yes
Uses events (listening/handling and triggering) to manage different behavior in views	yes - the bus is a little over-used in some places, but in general this is good
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render)	yes
Error handling for the Order Entry Form	yes
Testing
Has unit tests for models	yes
Overall	Good job overall! Event-driven programming is an important tool for the modern software engineer, especially in an asynchronous context like front-end JavaScript. It's also very different than the message-driven paradigm we've studied so far. Designing such programs is a unique challenge, as is knowing when and when not to use event-driven techniques. Keep studying and thinking about them, always trying to come up with cleaner, more robust designs, and keep up the hard work!

[droberts-sea]

I like that the Order knows which quote it's for. It's possible to achieve the same behavior through the bus, but the resulting code ends up being much more complex and hard to read.

[droberts-sea]

Good use of a model function.

Since you know what quote you need to buy/sell, it might be cleaner to call the this.quote.buy() or this.quote.sell() directly here rather than passing messages through the bus.

[droberts-sea]

This function and sellOrder are almost identical. Could you consolidate the two?