Amy Cash - Pipes - Ada Trader

[cashmonger]

Ada Trader

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How do Backbone Views help structure your code?	They mediate between the presentation in the browser and the data/models that you are presenting.
Did you use jQuery directly in your Views? How, and why?	Mainly for emptying and filling sections of HTML and appending generated data.
What was an example of an event you triggered? Why did you need to trigger it?	A record trade event, so that, when a trade happens, the current info can be displayed in the trade history view.
In what was is unit testing in JavaScript similar to unit testing in Ruby? In what ways is it different?	It's similar in terms of Describe and It blocks, but some of the specific syntax for setting up the tests is different.

[Hamled]

Ada Trader

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	✅
Comprehension questions	✅
Organization
Models and collections are defined in separate files	✅
Code that relies on the DOM is located in or called by $(document).ready	✅
Functionality
Quote prices change when clicking Buy and Sell	Mostly. This functionality does work, but the automatic price changes from the simulator are not working.
The Trade History updates when buying and selling a quote	✅
A user can create an open order using the Order Entry Form	✅
An open order removes itself from the open orders and updates the Trade History when fulfilled	No. The Order model is not connected to the Quote model by listening to its change event, so it can never execute when the price is correct.
General
Has separate views for different parts of the app	✅
Uses events (listening/handling and triggering) to manage different behavior in views	Mostly. There are some unnecessary event triggers, and some missing event connections for wave 3.
Practices good standards for views (ES6 syntax, doesn't directly use jQuery, returns this in render)	✅
Error handling for the Order Entry Form	✅
Testing
Has unit tests for models	No, only the provided tests for the Quote model's custom methods.
Overall	There are a few pieces missing from waves 1 & 3, and likely some confusion around how models should connect to each other through events. Otherwise, the project seems solid. I think your understanding of how to use Backbone Views to manage rendering and DOM events is good.

[Hamled]

We could probably use const here instead of let.

[Hamled]

It looks like triggering this event isn't doing anything, because there are no objects that are listening for it.

[Hamled]

This could also be written as:

orderData.quote = this.quoteList.findWhere({ symbol: orderData.symbol });

[Hamled]

I think the logic in this function could be moved into the Quote model, and have it be run as part of buy() or sell().

This would allow it to be tested more easily, and reduces the coupling between this view and its model.

[Hamled]

By passing quoteList here we are creating a view for a collection of quotes that is not connected to the simulator at all (and thus there appears to be no automatic change in prices).

If we insted write model: quotes, for this line then we'll be connecting this QuoteListView to the same collection of quotes as the simulator receives, which should solve the issue.