TEAM GLITZY- Tanja, Jan, Severin, and Amy by ayjlee · Pull Request #65 · Ada-C8/betsy

ayjlee · 2017-10-27T21:12:16Z

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	Task leads came up with work plan, delegated assignments. We group planned on design of MVC and database schema, and had a week 1 goal of completing functionality and tests for Guests, and week 2 goal for finishing Merchant functionality and tests. Tasks were divided into pair programming or solo assignments depending on difficulty, and interconnectedness, as well as individual strengths and goals.
How did your team utilize git to collaborate?	We primarily used git branches and pull requests.
What did your group do to try to keep your code DRY while many people collaborated on it?	We left time at the end to identify as a group areas for refactoring, then divide up refactoring tasks to DRY up code.
What was a technical challenge that you faced as a group?	Deploying to Heroku utilizing Paperclip and AWS authentication keys, checking for dependencies between gem versions before deploying, handling mismatches between local schema and Heroku schema in case of dropped migrations.
What was a team/personal challenge that you faced as a group?	At various points, team members faced frustrating episodes of learning how to use git better, the team rallied together to make sure that no one was left behind because everyone having a functional version of the repository was essential to moving forward.
What could your team have done better?	As a group, coming to a consensus about overall design and wireframes earlier in the process to avoid ambiguity and empower people to move forward style decisions based on the frameworks given.
What was your application's ERD? (include a link)	https://github.com/ayjlee/betsy/blob/master/erd.pdf
What is your Trello URL?	https://trello.com/b/8aCdTueZ/glitzy
What is the Heroku URL of your deployed application?	https://glitzy-store.herokuapp.com

…ation-page

…model-testing

…test

…ation-page

…m non-logged in users cannot update or delete a review

…#destroy tests

…merchants cannot edit their own products

…nly logged in users can edit reviews

…le product quantity

…it form

…been updated to include user info and status name(used to order_one now pending_order; order_two now paid_order)

…oduct show page, and updated the order of table columns

…by a little

…r is entered

…e between category names

Home Page Styling

… error message

CheezItMan · 2017-10-30T23:56:17Z

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	Good number of commits and a large number of commit messages.
Answered comprehension questions	Check, I'm glad branching helped and that you pulled together to keep everyone up.
Trello board is created and utilized in project management	It looks like you got most of what you wanted done!
Heroku instance is online	Check, nice
General
Nested routes follow RESTful conventions	Good RESTful routes where appropriate. You do have some unused routes still in your `routes.rb` file, like the users index action.
OAuth used for User authentication	Check
Functionality restricted based on user roles	As a merchant I can, by changing the URL edit and change another merchant's product. See here. The use of a filter would help ensure this.
Products can be added and removed from cart	Check
Users can view past orders	Check
Merchants can add, edit and view their products	Check
Errors are reported to the user	Check
Order Functionality
Reduces products' inventory	Check, but I can add a product twice allowing me to check out with more item than were in inventory.
Cannot order products that are out of stock	Check
Changes order state	Check
Clears current cart	Check
Database
ERD includes all necessary tables and relationships	The ERD isn't using standard notation, but has the models used and their relationships.
Table relationships	Relationships present.
Models
Validation rules for Models	Check, I like how you used the constant to list the possible order status states. I also like how you add validations for the product images with PaperClip.
Business logic is in the models	A good amount of business logic is in the models.
Controllers
Controller Filters used to DRY up controller code	Good use of the `render_404` method and filters like `find_user` and `current_order`. Some more DRYing up could be done however, like in the orders controller.
Testing
Model Testing	Lots of testing. I left some notes in the code
Controller Testing	Left some notes in your code. Good overall, you need to do more checks of status codes and flash messages.
Session Testing	Good session testing!
SimpleCov at 90% for controller and model tests	Almost exactly 90%
Front-end
The app is styled to create an attractive user interface	Very nicely done.
The app layout uses Foundation's Grid	Somewhat responsive. Some pages like fulfillment have issues with small sizes
Content is organized with HTML5 semantic tags	Some areas (product index and order index) still have divs where semantic tags would do better.
CSS is DRY	Some DRYing could be done, color layouts etc.
Overall	Very nicely done. You had almost all the functionality and a few bugs, but overall outstanding work.

CheezItMan

Left you some notes, overall nicely done!

CheezItMan · 2017-10-30T23:14:45Z

test/models/category_test.rb

+      food_category.products.first.must_be_kind_of Product
+
+      food_category.products << products(:tears)
+      food_category.products.count.must_equal 2


you should have a food_category.save here ensuring that no validations etc get broken.

CheezItMan · 2017-10-30T23:16:17Z

test/models/order_item_test.rb

+
+    it "requires that quantity is a positive integer " do
+      item1.quantity.must_be_kind_of Integer
+      item1.quantity.must_be :>, 0


These two seem redundant.

CheezItMan · 2017-10-30T23:23:45Z

test/models/order_item_test.rb

@@ -0,0 +1,53 @@
+require "test_helper"


No test for available? ???

Remember to test custom methods.

CheezItMan · 2017-10-30T23:25:35Z

test/models/order_test.rb

+
+  describe "validations" do
+
+    it "an order requires a status" do


I would also test if status is nil.

CheezItMan · 2017-10-30T23:27:24Z

test/models/order_test.rb

+    end
+  end
+
+  describe "custom model methods" do


Shouldn't the total_cost method be tested in here as opposed to outside?

CheezItMan · 2017-10-30T23:50:19Z

test/controllers/order_items_controller_test.rb

+      delete order_item_path(soap2.id)
+      #Assert
+      OrderItem.find_by(id: soap2.id).must_equal soap2
+      must_redirect_to order_path(paid.id)


Also some flash error message and status code should be tested.

CheezItMan · 2017-10-30T23:50:52Z

test/controllers/order_items_controller_test.rb

+    let(:merchant_order_item) {order_items(:orderitem4)}
+
+    it "ensures a paid order_item's default shipping status is: not shipped" do
+      login(merchant)


CheezItMan · 2017-10-30T23:52:06Z

test/controllers/orders_controller_test.rb

+      puts "order status is #{order.status}"
+      order.status.must_equal "incomplete"
+      patch place_order_path, params: order_data
+      order.status.must_equal "incomplete"


There should also be a status code and flash message to check.

CheezItMan · 2017-10-30T23:56:56Z

test/controllers/products_controller_test.rb

+
+  describe "edit" do
+    it "will get the edit form for an existing product" do
+      get edit_product_path(Product.first)


What about if the user isn't logged in!!!! OMG! Or if the user isn't the owner!

CheezItMan · 2017-10-30T23:57:25Z

test/controllers/products_controller_test.rb

+  describe "update" do
+
+    it "updates with valid data and an existing product " do
+      product = products(:chocolate)


s-wigg and others added 30 commits October 20, 2017 11:33

Merge branch 'master' of https://github.com/ayjlee/betsy

c43e694

place order page

747889c

Merge branch 'master' of https://github.com/ayjlee/betsy into confirm…

dba7d32

…ation-page

Merge branch 'master' of https://github.com/ayjlee/betsy into review-…

2c2bc71

…model-testing

Added review fixture let (one) statement for ReviewController#update …

dc6d861

…test

Updated Application.html.erb file for flash messages

fd1cf03

colors

7aebf8f

Merge branch 'master' of https://github.com/ayjlee/betsy into confirm…

b62f7fc

…ation-page

deleted Cart migration because cart model does not exist

a3d6229

updated product show page to include reviews and total cost

843f2f2

resolved merge conflicts

0b38b13

rescuing accidentially deleted confirmation page

b317de9

Added test for ReviewController #update and #destroy: tests to confir…

45a3f3c

…m non-logged in users cannot update or delete a review

fixed place order page merge conflict

c67b58c

Added Login or Session comment notes for ReviewController#update and …

e3e5468

…#destroy tests

finally getting the confimation page to work

050ea41

M:erge branch 'review-controller-testing'

9fccac8

rescuing order.rb

0cebbaf

Merge branch 'master' of https://github.com/ayjlee/betsy

675cd36

dropped carts table

9372c2e

Merge branch 'master' of https://github.com/ayjlee/betsy

e0b166a

revised styling for when no items in cart

5d14f66

Merge branch 'master' of https://github.com/ayjlee/betsy

145196d

ReviewControllerUpdate: Added review and product catch for merchant; …

e1946a8

…merchants cannot edit their own products

ReviewControllerUpdate: Edit Denial message changed to inform users o…

75592b3

…nly logged in users can edit reviews

Edited OrderItem form to limit the select options up to 20 or availab…

ac55d4b

…le product quantity

Merge branch 'master' of https://github.com/ayjlee/betsy

d146368

Added edit form to allow quantity change for order_item

e35fb9c

Updated OrderItem#update method to update order_item quantity from ed…

984eede

…it form

Update Order and User fixtures (order fixture names and content have …

7b7f4ec

…been updated to include user info and status name(used to order_one now pending_order; order_two now paid_order)

ayjlee and others added 28 commits October 27, 2017 00:32

Merge branch 'more-show-product-style'

000644b

styling to order_fulfillment page

d753874

styled account dashboard table to see thumbnails, click through to pr…

990baec

…oduct show page, and updated the order of table columns

added spacing between picture and product info, narrowed the content …

f56e562

…by a little

fixed show method to render404 and return when nonexisten order numbe…

277b5c6

…r is entered

updated application helper method #print_categories to include a spac…

30a8ee7

…e between category names

included comma separation instead fo just space separation

af9d4ff

Merge branch 'order-fulfillment-style'

ac63b06

updated button and link font colors on order fulfillment page

fcf5a02

removed view all orders button and fixed avg-rating display

98c1617

Home Page Styling

48540a1

Merge pull request #12 from Jan/home-fin

4dd545f

Home Page Styling

updated account user view and merged account-dashboard styling

3a01d34

got rid of underline on links

95a932c

deleted extraneous code

00d68ce

updated error message whe product is not saved, updated test with new…

160f4b6

… error message

aligned header texting to product photos

d99d12d

new review styling

e861bff

updated header number on by_merchant page

5bf0c6f

Merge branch 'master' of https://github.com/ayjlee/betsy

192757e

Merge branch 'fix-spacing'

d3c110b

added orders controller test

4e145c0

Merge branch 'master' of https://github.com/ayjlee/betsy

5cfc4f0

set max height and overflow scroll for all content pages

6cb16e7

Merge branch 'master' of https://github.com/ayjlee/betsy

a38c224

updated add new order item form language

2d07862

cleanup

f3b94ca

Update README.md

fd4f2c2

CheezItMan reviewed Oct 30, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEAM GLITZY- Tanja, Jan, Severin, and Amy#65

TEAM GLITZY- Tanja, Jan, Severin, and Amy#65
ayjlee wants to merge 388 commits intoAda-C8:masterfrom
ayjlee:master

ayjlee commented Oct 27, 2017

Uh oh!

CheezItMan commented Oct 30, 2017

Uh oh!

CheezItMan left a comment

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

CheezItMan Oct 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ayjlee commented Oct 27, 2017

bEtsy

Comprehension Questions

Uh oh!

CheezItMan commented Oct 30, 2017

bEtsy

What We're Looking For

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants