Amy Lee -- Carets

[ayjlee]

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I made Blocks a separate class/distinct object, and I made Block Reservations a subclass of Reservations. Initially, I was just going to make a Blocks class that would somehow relate to or inherit from Reservations. However, I realized a Block was a different kind of container, which dictates which rooms you are allowed to reserve, and what dates. Reservations for rooms in blocks had all the same methods and variables as Reservations, but behaved a bit differently or had different default values. Because these changes were minimal, but significant, I decided to make Block Reservations a subclass of Reservations.
Describe a concept that you gained more clarity on as you worked on this assignment.	Over-designing and separately, SRP. I caught myself writing code for features that were not asked for, but that I thought a Hotel reservation system should be capable of. Also, I found that SRP is easy to understand in theory, but hard for me to implement in practice.
Describe a nominal test that you wrote for this assignment.	I tested that the available_rooms method was returning an updated array of all available rooms by date as reservations or blocks were made.
Describe an edge case test that you wrote for this assignment.	An edge case I tested for in thinking about user input error prevention was raising an error if anybody entered a date from the past for check-in or check-out.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	Writing pseudocode was a good learning experience- it helped me to clarify the design choices I needed to make by encouraging me to narrate the actions I wanted to take and follow the intended consequences of those actions on the classes in my code. However, I think I spent too much time going back and forth with my design, and this meant that I would write some tests, write code, have a thought, write a bunch of code to test the new idea, and then realize that I should write some more tests. Unfortunately, I don't think I implemented TDD practices well (in favor of following the thread of an idea and updated codes as it affected different elements of my program), or the principle of Separation of Concerns. In retrospect, I feel like I MacGyver-ed my way through Hotel- it was fun to think through and create, should work for the given requirements and constraints, but is not the most well-designed or efficient solution.

[tildeee]

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	x
Answer comprehension questions	x
Design
Each class is responsible for a single piece of the program	x
Classes are loosely coupled	x
Wave 1
List rooms	x
Reserve a room for a given date range	x
List reservations for a given date	x
Calculate reservation price	x
Invalid date range produces an error	x
Test coverage	x, missing one for "can list rooms" technically
Wave 2
View available rooms for a given date range	x
Reserving a room that is not available produces an error	x
Test coverage	x
Wave 3
Create a block of rooms	x
Check if a block has rooms	x
Reserve a room from a block	x
Test coverage	x
Additional Feedback

[tildeee]

at each iteration, because you're resetting the values of guest_idx and res_idx in lines 164 and 165, incrementing them here doesn't actually affect the code

Your tests pass because you aren't testing for this logic/asserting that the guest and res ids are set!

[tildeee]

you can probably do this same thing with

NUM_STANDARD_ROOMS.times do |index|
  room = HotelBooking::Room.new(index + 1)
  standard_rooms << room
end

or

(1..NUM_STANDARD_ROOMS).each do |index|
instead of needing to increment with i if you wanted to

[tildeee]

What are @reserv_ids for?

[tildeee]

Hey Amy! Sorry that my review of your code took a long time.

Overall, I'm really pleased with your Hotel class.

I have questions about how you designed the Room class-- it seems like it has some responsibilities about making block reservations and I'm not sure it's appropriate.

I don't know how much you need Reservation to have id

[tildeee]

I love all the small helper methods you made :D I wish that there were a better place to put this specific helper method about checking if it's a valid date that wasn't in Hotel, but I can't think of a better place at the moment.

[tildeee]

You might want to pick a different Error besides ArgumentError (like even writing a custom Error!)