Ampers - Sara S - Hotel by CheerOnMars · Pull Request #32 · Ada-C9/hotel

CheerOnMars · 2018-03-12T15:34:11Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	I had to decide how to group methods into blocks. I would like to create a Block Class in order to move towards classes with fewer responsibility, but I decided to wait until the refactor portion so I could make sure I could get the methods to work first.
Describe a concept that you gained more clarity on as you worked on this assignment.
Describe a nominal test that you wrote for this assignment.	For the test for the calculating reservation cost method, I made sure that a reservation of 5 nights would cost $1000.
Describe an edge case test that you wrote for this assignment.	One edge case was putting in a reservation end date that was before the reservation start date.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I thought it was helpful to write the pseudocode first because it helped me keep the classes, variables, and methods straight. It's easy to lose track, but the pseudocode was a useful reference sheet.

…for a date

… so that it'd be uniform for rake

…or start and end dates

….rb for added clarity

… classes and tests as a result

… seconds

…rooms and views a list of rooms that aren't reserved for a given range

…d access_reservation method to remove strftime(%Y-%m-%d) functionality

…lib/hotel_admin.rb

…om method in hotel class.rb

kariabancroft · 2018-03-19T17:12:02Z

lib/hotel_admin.rb

+    def add_reservation(reservation)
+      #note: this is tightly coupled, I think.
+      @reservations << reservation
+      @reservation = reservation


Why set this as an instance variable here?

kariabancroft · 2018-03-19T17:12:34Z

lib/hotel_admin.rb

+    end
+
+    def calc_reservations(reservation)
+      reservation.price_night * reservation.calc_duration


I think this logic would be better inside the reservation object

kariabancroft · 2018-03-19T17:14:02Z

lib/hotel_admin.rb

+
+    def create_block(input)
+
+      if input[:block_start_date] == nil || input[:block_end_date] == nil


All of this data validation should be in an initialize somewhere

kariabancroft · 2018-03-19T17:16:46Z

Hotel

What We're Looking For

Feature	Feedback
Design
Demonstrated classes having a single responsibility	Room for improvement - it is easy to fill up the `HotelAdmin` class with lots of logic that doesn't need to be there. I think you have a few instances of this, so keep this in mind.
Demonstrated loose coupling	Yes - though the `HotelAdmin` is doing some things that it doesn't need to do, I think you generally do try to keep the separation between objects.
Methods demonstrate a good use of encapsulation, inputs and outputs	Yes
Wave 1 requirements	Yes
Wave 2 requirements	Yes
Wave 3 requirements	Yes

CheerOnMars added 30 commits March 5, 2018 15:03

add reservation class and test methods

cdcf55f

updated length method to ensure output is an integer

8587c1f

created room class, method, and test file

f5f634c

create spec helper

c547e7b

created hotel_admin method and tests to return array of reservations …

a3fdcdd

…for a date

updated filed names so they could be read by rake

45907e8

created Rakefile

f1e264e

changed name of local variage in initialize method in Room class

a7db229

deleted room_specs.rb and replaced it with room_spec.rb

4dd8d16

deleted reservation_specs.rb and replaced it with reservation_spec.rb…

f99f765

… so that it'd be uniform for rake

add room to initialize method in reservation class, add self method f…

509fef8

…or start and end dates

corrected method to access reservations for a certain day

3821f9e

changed start_date and end_date to checkin_date and checkout_date

66170d4

adjusted variable names in lib/hotel_admin.rb for added clarity

de77f64

updated tests for HotelAdmin's method of returning rooms

daddef4

adjusted variable names in lib/room.rb for added clarity

3680efe

adjusted method names in lib/reservation.rb for added clarity

883b1a1

updated tests to account for adjusted method names in lib/reservation…

ca4ff0d

….rb for added clarity

rearranged order of hotel_admin tests

44b474c

rearrange order of methods

ee581ee

removed room class and specs, added room to HotelAdmin class. updated…

3aee111

… classes and tests as a result

updated reservation class to grey out lines that parsed the date into…

32815d1

… seconds

add test to HotelAdmin class to check that returns a list of all the …

c633a11

…rooms and views a list of rooms that aren't reserved for a given range

In HotelAdmin class, added method to view available rooms, and change…

de23dda

…d access_reservation method to remove strftime(%Y-%m-%d) functionality

removed unnecessary comments

9fef03e

removed unnecessary comments and added reserve_available_room method …

779da5c

…lib/hotel_admin.rb

removed unnecessary comments and added tests for reserve_available_ro…

a217f7e

…om method in hotel class.rb

trimmed down the tests for the HotelAdmin class's methods

21fbb57

add block class lib and spec files

5982f91

added lib/block and removed lib/room as required relatives

474e97d

CheerOnMars added 12 commits March 11, 2018 21:56

removed lib/room as required relative

428a5a9

holding off on making block its own class for now

edb3810

holding off on making block its own class for now

a0042c2

small format change

ba3c378

updated HotelAdmin class and its tests to include block functionality

9c6e3e4

add status to reservation class

60231d0

update method for room holds, add appropriate tests

74b830f

removed unncessary status and price_night methods

d217828

added missing comma

d2e68c9

added party_name to reservations class

f728d7d

tried to update status

f8ac9ef

tried to update method and tests to reserve a room in a block

6c512e0

kariabancroft reviewed Mar 19, 2018

View reviewed changes

corrected design-activity

256953b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Ampers - Sara S - Hotel#32

Ampers - Sara S - Hotel#32
CheerOnMars wants to merge 43 commits intoAda-C9:masterfrom
CheerOnMars:master

CheerOnMars commented Mar 12, 2018

Uh oh!

kariabancroft Mar 19, 2018

Uh oh!

kariabancroft Mar 19, 2018

Uh oh!

kariabancroft Mar 19, 2018

Uh oh!

kariabancroft commented Mar 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		def create_block(input)

		if input[:block_start_date] == nil \|\| input[:block_end_date] == nil

Comments

Conversation

CheerOnMars commented Mar 12, 2018

Hotel

Comprehension Questions

Uh oh!

kariabancroft Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

kariabancroft Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

kariabancroft Mar 19, 2018

Choose a reason for hiding this comment

Uh oh!

kariabancroft commented Mar 19, 2018

Hotel

What We're Looking For

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants