JS Scrabble - Octos- Cara Brennan#22
Open
MississippiBrenn wants to merge 2 commits intoAda-C9:masterfrom
Open
Conversation
JS ScrabbleWhat We're Looking For
|
| const SCORING_RUBRIK = { | ||
| 'a': 1, | ||
| 'e': 1, | ||
| 'i': 1, |
There was a problem hiding this comment.
I like the use of a hash to store this information - good instincts! However, defining it inside the method ends up being a little cumbersome. Putting it at the top of the file might be a little more readable.
| if (!RegExp(/^[a-zA-Z]+$/).test(letter)){ | ||
|
|
||
| throw `Letters only please. Letter: ${letter} i == ${i} word: ${word}` | ||
| } |
There was a problem hiding this comment.
It would be a little faster to test this regular expression against the whole word outside the loop.
| highestWordScoreWord(arrayOfWords) { | ||
| let highWord = '' | ||
| let highScore = -1 | ||
| if (arrayOfWords.length === 0){ |
There was a problem hiding this comment.
You've got almost exactly the same logic duplicated between here and highestScoreFrom. Could you DRY these up somehow?
| tiebreaker(challenger, incumbent){ | ||
| if (incumbent.length === 7){ | ||
| return incumbent; | ||
| }else if (challenger.length === 7){ |
There was a problem hiding this comment.
I like the use of a helper method to clarify this logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions